Address Tomer's review comments

Author: yim-lee

Sources/PackageCollections/PackageCollections.swift

@@ -64,13 +64,13 @@ public struct PackageCollections: PackageCollectionsProtocol {
          storage: Storage,
          collectionProviders: [Model.CollectionSourceType: PackageCollectionProvider],
          metadataProvider: PackageMetadataProvider,
-         searchProvider: PackageSearchProvider? = nil) {
+         customSearchProvider: PackageSearchProvider? = nil) {
         self.configuration = configuration
         self.observabilityScope = observabilityScope
         self.storageContainer = (storage, false)
         self.collectionProviders = collectionProviders
         self.metadataProvider = metadataProvider
-        self.searchProvider = searchProvider ?? StorageBackedPackageSearchProvider(storage: storage.collections)
+        self.searchProvider = customSearchProvider ?? StorageBackedPackageSearchProvider(storage: storage.collections)
     }
 
     public func shutdown() throws {

Sources/PackageCollections/Providers/PackageSearchProvider.swift

@@ -13,7 +13,7 @@ import PackageModel
 import TSCBasic
 
 /// Package search API provider
-protocol PackageSearchProvider: Closable {
+protocol PackageSearchProvider {
     /// The name of the provider
     var name: String { get }
 

Sources/PackageCollections/Providers/StorageBackedPackageSearchProvider.swift

@@ -48,8 +48,4 @@ struct StorageBackedPackageSearchProvider: PackageSearchProvider {
                        callback: @escaping (Result<PackageCollectionsModel.TargetSearchResult, Error>) -> Void) {
         self.searchTargets(query, searchType: searchType, collections: nil, callback: callback)
     }
-
-    func close() throws {
-        // No need to do anything
-    }
 }