Skip to content

Commit 5b445bc

Browse files
authored
remove graph loading on package update (#7072)
motivation: consistent behavior between pacakge update and package resolve changes: do not attempt to load the dependencies graph (which performs additional validations), this means validation is deferred until build is attempted rdar://113413552
1 parent 5f5b98b commit 5b445bc

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

Sources/Commands/PackageTools/Update.swift

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -42,14 +42,6 @@ extension SwiftPackageTool {
4242
observabilityScope: swiftTool.observabilityScope
4343
)
4444

45-
// try to load the graph which will emit any errors
46-
if !swiftTool.observabilityScope.errorsReported {
47-
_ = try workspace.loadPackageGraph(
48-
rootInput: swiftTool.getWorkspaceRoot(),
49-
observabilityScope: swiftTool.observabilityScope
50-
)
51-
}
52-
5345
if self.dryRun, let changes = changes, let pinsStore = swiftTool.observabilityScope.trap({ try workspace.pinsStore.load() }){
5446
self.logPackageChanges(changes: changes, pins: pinsStore)
5547
}

0 commit comments

Comments
 (0)