Always return .success when compiler has non-zero exit status

pcbeard · pcbeard · commit 5bcf58cb283b · 2021-12-02T12:02:27.000-08:00
This is required for unit tests to pass.
diff --git a/Sources/PackageLoading/ManifestLoader.swift b/Sources/PackageLoading/ManifestLoader.swift
@@ -855,7 +855,7 @@ public final class ManifestLoader: ManifestLoaderProtocol {
 
                 // Return now if there was an error.
                 if compilerResult.exitStatus != .terminated(code: 0) {
-                    return completion(.failure(ProcessResult.Error.nonZeroExit(compilerResult)))
+                    return completion(.success(evaluationResult))
                 }
 
                 // Pass an open file descriptor of a file to which the JSON representation of the manifest will be written.

Original file line number	Diff line number	Diff line change
`@@ -855,7 +855,7 @@ public final class ManifestLoader: ManifestLoaderProtocol {`
`855`	`855`
`856`	`856`	`// Return now if there was an error.`
`857`	`857`	`if compilerResult.exitStatus != .terminated(code: 0) {`
`858`		`- return completion(.failure(ProcessResult.Error.nonZeroExit(compilerResult)))`
	`858`	`+ return completion(.success(evaluationResult))`
`859`	`859`	`}`
`860`	`860`
`861`	`861`	`// Pass an open file descriptor of a file to which the JSON representation of the manifest will be written.`