fix mirrors functional test (#6437)

tomerd · web-flow · commit 5da108a2e59a · 2023-04-17T14:33:15.000-07:00
motivation: test coverage

change: update fixture to not force package name which is deprecated when using URLs

rdar://107970938
diff --git a/Fixtures/DependencyResolution/External/Mirror/App/Package.swift b/Fixtures/DependencyResolution/External/Mirror/App/Package.swift
@@ -5,8 +5,8 @@ import PackageDescription
 let package = Package(
     name: "App",
     dependencies: [
-        .package(name: "Foo", url: "../Foo", .branch("main")),
-        .package(name: "Bar", url: "../Bar", .branch("main")),
+        .package(url: "../Foo", .branch("main")),
+        .package(url: "../Bar", .branch("main")),
     ],
     targets: [
         .target(name: "App", dependencies: [
diff --git a/Tests/FunctionalTests/DependencyResolutionTests.swift b/Tests/FunctionalTests/DependencyResolutionTests.swift
@@ -78,8 +78,6 @@ class DependencyResolutionTests: XCTestCase {
     }
 
     func testMirrors() throws {
-        try XCTSkipIf(true, "test is broken and needs investigation rdar://107970938")
-
         try fixture(name: "DependencyResolution/External/Mirror") { fixturePath in
             let prefix = try resolveSymlinks(fixturePath)
             let appPath = prefix.appending("App")

Original file line number	Diff line number	Diff line change
`@@ -78,8 +78,6 @@ class DependencyResolutionTests: XCTestCase {`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`func testMirrors() throws {`
`81`		`- try XCTSkipIf(true, "test is broken and needs investigation rdar://107970938")`
`82`		`-`
`83`	`81`	`try fixture(name: "DependencyResolution/External/Mirror") { fixturePath in`
`84`	`82`	`let prefix = try resolveSymlinks(fixturePath)`
`85`	`83`	`let appPath = prefix.appending("App")`