fix PkgConfigHint test on systems that do not have pkg-config instaled (#3757)

tomerd · web-flow · commit 72bc79b7f044 · 2021-09-18T20:20:58.000-07:00
motivation: fix CI

changes: change assumption in test about single diagnostic emitted, as there may be more on systems that do not have pkg-config instaled
diff --git a/Tests/BuildTests/BuildPlanTests.swift b/Tests/BuildTests/BuildPlanTests.swift
@@ -1624,11 +1624,10 @@ final class BuildPlanTests: XCTestCase {
             fileSystem: fileSystem
         )
 
-        guard let diagnostic = observability.diagnostics.first else {
-            return XCTFail("Expected a diagnostic")
-        }
-        XCTAssertMatch(diagnostic.message, .contains("you may be able to install BTarget using your system-packager"))
-        XCTAssertEqual(diagnostic.severity, .warning)
+        XCTAssertTrue(observability.diagnostics.contains(where: {
+            $0.severity == .warning &&
+            $0.message.hasPrefix("you may be able to install BTarget using your system-packager")
+        }), "expected PkgConfigHint diagnostics")
     }
 
     func testPkgConfigGenericDiagnostic() throws {

Original file line number	Diff line number	Diff line change
`@@ -1624,11 +1624,10 @@ final class BuildPlanTests: XCTestCase {`
`1624`	`1624`	`fileSystem: fileSystem`
`1625`	`1625`	`)`
`1626`	`1626`
`1627`		`- guard let diagnostic = observability.diagnostics.first else {`
`1628`		`- return XCTFail("Expected a diagnostic")`
`1629`		`- }`
`1630`		`- XCTAssertMatch(diagnostic.message, .contains("you may be able to install BTarget using your system-packager"))`
`1631`		`- XCTAssertEqual(diagnostic.severity, .warning)`
	`1627`	`+ XCTAssertTrue(observability.diagnostics.contains(where: {`
	`1628`	`+ $0.severity == .warning &&`
	`1629`	`+ $0.message.hasPrefix("you may be able to install BTarget using your system-packager")`
	`1630`	`+ }), "expected PkgConfigHint diagnostics")`
`1632`	`1631`	`}`
`1633`	`1632`
`1634`	`1633`	`func testPkgConfigGenericDiagnostic() throws {`