improve build complete message (#3825)

motivation: when no work needs to be done the output is [0/0] Build complete! which is confusing

changes: treat the build complete step as a descrete step incrementing the step + total counts

Author: tomerd

Sources/Build/BuildOperationBuildSystemDelegateHandler.swift

@@ -621,13 +621,12 @@ final class BuildOperationBuildSystemDelegateHandler: LLBuildBuildSystemDelegate
 
     func buildComplete(success: Bool) {
         queue.sync {
+            self.progressAnimation.complete(success: success)
             if success {
-                self.progressAnimation.update(
-                    step: self.taskTracker.finishedCount,
-                    total: self.taskTracker.totalCount,
-                    text: "Build complete!")
+                self.progressAnimation.clear()
+                self.outputStream <<< "Build complete!\n"
+                self.outputStream.flush()
             }
-            self.progressAnimation.complete(success: success)
         }
     }
 

Tests/CommandsTests/BuildToolTests.swift

@@ -273,13 +273,14 @@ final class BuildToolTests: XCTestCase {
             do {
                 let result = try execute([], packagePath: path)
                 // Number of steps must be greater than 0. e.g., [8/8] Build complete!
-                XCTAssertMatch(result.stdout, .regex("\\[[1-9][0-9]*\\/[1-9][0-9]*\\] Build complete!"))
+                XCTAssertMatch(result.stdout, .regex("\\[[1-9][0-9]*\\/[1-9][0-9]*\\] Linking Foo"))
+                XCTAssertMatch(result.stdout, .suffix("\nBuild complete!\n"))
             }
 
             do {
                 let result = try execute([], packagePath: path)
                 // test second time, to make sure message is presented even when nothing to build (cached)
-                XCTAssertMatch(result.stdout, .contains("[0/0] Build complete!"))
+                XCTAssertMatch(result.stdout, .equal("[1/1] Planning build\nBuild complete!\n"))
             }
         }
     }