Make PackageCollectionsSigningLibc dep conditional on supported platforms. (#6043)

drodriguez · web-flow · commit 807d1e98b6e1 · 2023-01-17T10:43:24.000+01:00
PackageCollectionsSigningLibc is only available in Linux, Android and Windows. However, PackageCollectionsSigning dependency on it is unconditional. This does not matter in because the target and the dependency are added only for the supported platforms, but with the recently introduced #5784, the conditional code can be removed and the manifest can be simplified. At the moment we can only add the dependency condition, because #5784 is not released yet, and Xcode's `swift build` will not correctly discard the target when building all targets just yet.
diff --git a/Package.swift b/Package.swift
@@ -82,7 +82,14 @@ packageCollectionsSigningTargets.append(
         ]
     )
 )
-packageCollectionsSigningDeps.append("PackageCollectionsSigningLibc")
+packageCollectionsSigningDeps.append(
+    .target(
+        name: "PackageCollectionsSigningLibc",
+        condition: .when(
+            platforms: [.linux, .android, .windows]
+        )
+    )
+)
 #endif
 // Define PackageCollectionsSigning target always
 packageCollectionsSigningTargets.append(

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,14 @@ packageCollectionsSigningTargets.append(`
`82`	`82`	`]`
`83`	`83`	`)`
`84`	`84`	`)`
`85`		`-packageCollectionsSigningDeps.append("PackageCollectionsSigningLibc")`
	`85`	`+packageCollectionsSigningDeps.append(`
	`86`	`+ .target(`
	`87`	`+ name: "PackageCollectionsSigningLibc",`
	`88`	`+ condition: .when(`
	`89`	`+ platforms: [.linux, .android, .windows]`
	`90`	`+ )`
	`91`	`+ )`
	`92`	`+)`
`86`	`93`	`#endif`
`87`	`94`	`// Define PackageCollectionsSigning target always`
`88`	`95`	`packageCollectionsSigningTargets.append(`