Remove remaining difference with main

Author: dschaefer2

Sources/Basics/Graph/GraphAlgorithms.swift

@@ -131,50 +131,3 @@ public func depthFirstSearch<T: Hashable>(
         }
     }
 }
-
-/// Implements a pre-order depth-first search that traverses the whole graph and
-/// doesn't distinguish between unique and duplicate nodes. The visitor can abort
-/// a path as needed to prune the tree.
-/// The method expects the graph to be acyclic but doesn't check that.
-///
-/// - Parameters:
-///   - nodes: The list of input nodes to sort.
-///   - successors: A closure for fetching the successors of a particular node.
-///   - onNext: A callback to indicate the node currently being processed
-///             including its parent (if any) and its depth. Returns whether to
-///             continue down the current path.
-///
-/// - Complexity: O(v + e) where (v, e) are the number of vertices and edges
-/// reachable from the input nodes via the relation.
-public enum DepthFirstContinue {
-    case `continue`
-    case abort
-}
-
-public func depthFirstSearch<T: Hashable>(
-    _ nodes: [T],
-    successors: (T) throws -> [T],
-    visitNext: (T, _ parent: T?) throws -> DepthFirstContinue
-) rethrows {
-    var stack = OrderedSet<TraversalNode<T>>()
-
-    for node in nodes {
-        precondition(stack.isEmpty)
-        stack.append(TraversalNode(parent: nil, curr: node))
-
-        while !stack.isEmpty {
-            let node = stack.removeLast()
-
-            if try visitNext(node.curr, node.parent) == .continue {
-                for succ in try successors(node.curr) {
-                    stack.append(
-                        TraversalNode(
-                            parent: node.curr,
-                            curr: succ
-                        )
-                    )
-                }
-            }
-        }
-    }
-}

Sources/Build/BuildDescription/ModuleBuildDescription.swift

@@ -187,30 +187,8 @@ extension ModuleBuildDescription {
         var dependencies: [Dependency] = []
         plan.traverseDependencies(of: self) { product, _, description in
             dependencies.append(.product(product, description))
-            return .continue
         } onModule: { module, _, description in
             dependencies.append(.module(module, description))
-            return .continue
-        }
-        return dependencies
-    }
-
-    package func recursiveLinkDependencies(using plan: BuildPlan) -> [Dependency] {
-        var dependencies: [Dependency] = []
-        plan.traverseDependencies(of: self) { product, _, description in
-            guard product.type != .macro && product.type != .plugin else {
-                return .abort
-            }
-
-            dependencies.append(.product(product, description))
-            return .continue
-        } onModule: { module, _, description in
-            guard module.type != .macro && module.type != .plugin else {
-                return .abort
-            }
-
-            dependencies.append(.module(module, description))
-            return .continue
         }
         return dependencies
     }

Sources/Build/BuildPlan/BuildPlan.swift

@@ -1175,8 +1175,8 @@ extension BuildPlan {
 
     package func traverseDependencies(
         of description: ModuleBuildDescription,
-        onProduct: (ResolvedProduct, BuildParameters.Destination, ProductBuildDescription?) -> DepthFirstContinue,
-        onModule: (ResolvedModule, BuildParameters.Destination, ModuleBuildDescription?) -> DepthFirstContinue
+        onProduct: (ResolvedProduct, BuildParameters.Destination, ProductBuildDescription?) -> Void,
+        onModule: (ResolvedModule, BuildParameters.Destination, ModuleBuildDescription?) -> Void
     ) {
         var visited = Set<TraversalNode>()
         func successors(
@@ -1217,16 +1217,16 @@ extension BuildPlan {
             case .package:
                 []
             }
-        } visitNext: { module, _ in
+        } onNext: { module, _ in
             switch module {
             case .package:
-                return .continue
+                break
 
             case .product(let product, let destination):
-                return onProduct(product, destination, self.description(for: product, context: destination))
+                onProduct(product, destination, self.description(for: product, context: destination))
 
             case .module(let module, let destination):
-                return onModule(module, destination, self.description(for: module, context: destination))
+                onModule(module, destination, self.description(for: module, context: destination))
             }
         }
     }

Tests/BuildTests/BuildPlanTraversalTests.swift

@@ -146,10 +146,8 @@ final class BuildPlanTraversalTests: XCTestCase {
             XCTAssertEqual(product.name, "SwiftSyntax")
             XCTAssertEqual(destination, .host)
             XCTAssertNil(description)
-            return .continue
         } onModule: { module, destination, description in
             moduleDependencies.append((module, destination, description))
-            return .continue
         }
 
         XCTAssertEqual(moduleDependencies.count, 2)

Utilities/build-using-self

@@ -163,7 +163,6 @@ def filterNone(items: t.Iterable) -> t.Iterable:
 
 def main() -> None:
     args = get_arguments()
-    ignore = "-Xlinker /ignore:4217" if os.name == "nt" else ""
     logging.getLogger().setLevel(logging.DEBUG if args.is_verbose else logging.INFO)
     logging.debug("Args: %r", args)
     ignore_args = ["-Xlinker", "/ignore:4217"] if os.name == "nt" else []