Apply suggestions from code review

Co-authored-by: Boris Bügling <[email protected]>
Co-authored-by: Yim Lee <[email protected]>

Author: 3 people

Sources/PackageCollections/Model/Collection.swift

@@ -77,6 +77,11 @@ extension PackageCollectionsModel {
 
         /// URL of the source file
         public let url: URL
+        
+        public init(type: PackageCollectionsModel.CollectionSourceType = .feed, url: URL) {
+             self.type = type
+             self.url = url
+         }
     }
 
     /// Represents the source type of a `PackageCollection`

Sources/PackageCollections/PackageCollections+Storage.swift

@@ -29,7 +29,7 @@ extension PackageCollections.Storage {
             }
         }
 
-        if let closabe = self.collections as? Closable {
+        if let closable = self.collections as? Closable {
             do {
                 try closabe.close()
             } catch {

Sources/PackageCollections/PackageCollections.swift

@@ -41,8 +41,8 @@ internal struct PackageCollections: PackageCollectionsProtocol {
                 if identifiers.isEmpty {
                     return callback(.success([]))
                 }
-                let groupOrder = identifiers.enumerated().reduce([PackageCollectionsModel.CollectionIdentifier: Int]()) { partial, element in
-                    var map = partial
+                let collectionOrder = identifiers.enumerated().reduce([PackageCollectionsModel.CollectionIdentifier: Int]()) { partial, element in
+                    var dictionary = partial
                     map[element.element] = element.offset
                     return map
                 }
@@ -51,7 +51,7 @@ internal struct PackageCollections: PackageCollectionsProtocol {
                     case .failure(let error):
                         callback(.failure(error))
                     case .success(var groups):
-                        // re-order by storage order which reflects the user's election
+                        // re-order by profile order which reflects the user's election
                         groups.sort(by: { lhs, rhs in groupOrder[lhs.identifier] ?? 0 < groupOrder[rhs.identifier] ?? 0 })
                         callback(.success(groups))
                     }
@@ -176,7 +176,7 @@ internal struct PackageCollections: PackageCollectionsProtocol {
                     return callback(.failure(UnknownProvider(source.type)))
                 }
                 provider.get(source, callback: callback)
-            case .success(let group):
+            case .success(let collection):
                 callback(.success(group))
             }
         }