[PackageGraph] Direct attempts to find first package/target by name through the graph

First step on the way to hide and remove `all{Products, Targets}`
from modules graph because with cross-compilation attempting to
fetch data from them directly could produce surprising results
since they don't always account for build triples.

Author: xedin

Sources/Build/BuildOperation.swift

@@ -894,13 +894,13 @@ extension BuildSubset {
         case .allExcludingTests:
             return graph.reachableTargets.filter { $0.type != .test }
         case .product(let productName):
-            guard let product = graph.allProducts.first(where: { $0.name == productName }) else {
+            guard let product = graph.product(for: productName) else {
                 observabilityScope.emit(error: "no product named '\(productName)'")
                 return nil
             }
             return try product.recursiveTargetDependencies()
         case .target(let targetName):
-            guard let target = graph.allTargets.first(where: { $0.name == targetName }) else {
+            guard let target = graph.target(for: targetName) else {
                 observabilityScope.emit(error: "no target named '\(targetName)'")
                 return nil
             }
@@ -920,7 +920,7 @@ extension BuildSubset {
         case .allIncludingTests:
             return LLBuildManifestBuilder.TargetKind.test.targetName
         case .product(let productName):
-            guard let product = graph.allProducts.first(where: { $0.name == productName }) else {
+            guard let product = graph.product(for: productName) else {
                 observabilityScope.emit(error: "no product named '\(productName)'")
                 return nil
             }
@@ -937,7 +937,7 @@ extension BuildSubset {
                 try product.getLLBuildTargetName(buildParameters: buildParameters)
             }
         case .target(let targetName):
-            guard let target = graph.allTargets.first(where: { $0.name == targetName }) else {
+            guard let target = graph.target(for: targetName) else {
                 observabilityScope.emit(error: "no target named '\(targetName)'")
                 return nil
             }

Sources/Build/BuildPlan/BuildPlan.swift

@@ -595,7 +595,7 @@ public class BuildPlan: SPMBuildCore.BuildPlan {
         arguments.append("-l" + replProductName)
 
         // The graph should have the REPL product.
-        assert(self.graph.allProducts.first(where: { $0.name == replProductName }) != nil)
+        assert(self.graph.product(for: replProductName) != nil)
 
         // Add the search path to the directory containing the modulemap file.
         for target in self.targets {

Sources/Commands/Snippets/Cards/SnippetCard.swift

@@ -96,7 +96,7 @@ struct SnippetCard: Card {
         let buildSystem = try swiftCommandState.createBuildSystem(explicitProduct: snippet.name)
         try buildSystem.build(subset: .product(snippet.name))
         let executablePath = try swiftCommandState.productsBuildParameters.buildPath.appending(component: snippet.name)
-        if let exampleTarget = try buildSystem.getPackageGraph().allTargets.first(where: { $0.name == snippet.name }) {
+        if let exampleTarget = try buildSystem.getPackageGraph().target(for: snippet.name) {
             try ProcessEnv.chdir(exampleTarget.sources.paths[0].parentDirectory)
         }
         try exec(path: executablePath.pathString, args: [])

Sources/Commands/Utilities/PluginDelegate.swift

@@ -385,7 +385,7 @@ final class PluginDelegate: PluginInvocationDelegate {
 
         // Find the target in the build operation's package graph; it's an error if we don't find it.
         let packageGraph = try buildSystem.getPackageGraph()
-        guard let target = packageGraph.allTargets.first(where: { $0.name == targetName }) else {
+        guard let target = packageGraph.target(for: targetName) else {
             throw StringError("could not find a target named “\(targetName)”")
         }
 

Sources/PackageGraph/ModulesGraph.swift

@@ -166,6 +166,16 @@ public struct ModulesGraph {
         package.dependencies.compactMap { self.package(for: $0) }
     }
 
+    public func product(for name: String) -> ResolvedProduct? {
+        // FIXME: This is wrong since graph can contain products with the same name but different triples.
+        self.allProducts.first { $0.name == name }
+    }
+
+    public func target(for name: String) -> ResolvedModule? {
+        // FIXME: This is wrong since graph can contain products with the same name but different triples.
+        self.allTargets.first { $0.name == name }
+    }
+
     /// All root and root dependency packages provided as input to the graph.
     public let inputPackages: [ResolvedPackage]
 

Sources/SPMBuildCore/Plugins/PluginInvocation.swift

@@ -677,7 +677,7 @@ public extension PluginTarget {
                 executableOrBinaryTarget = target
             case .product(let productRef, _):
                 guard
-                    let product = packageGraph.allProducts.first(where: { $0.name == productRef.name }),
+                    let product = packageGraph.product(for: productRef.name),
                     let executableTarget = product.targets.map({ $0.underlying }).executables.spm_only
                 else {
                     throw StringError("no product named \(productRef.name)")

Tests/PackageGraphTests/ModulesGraphTests.swift

@@ -84,12 +84,12 @@ final class ModulesGraphTests: XCTestCase {
         }
 
         let fooPackage = try XCTUnwrap(g.package(for: .plain("Foo")))
-        let fooTarget = try XCTUnwrap(g.allTargets.first{ $0.name == "Foo" })
-        let fooDepTarget = try XCTUnwrap(g.allTargets.first{ $0.name == "FooDep" })
+        let fooTarget = try XCTUnwrap(g.target(for: "Foo"))
+        let fooDepTarget = try XCTUnwrap(g.target(for: "FooDep"))
         XCTAssertEqual(g.package(for: fooTarget)?.id, fooPackage.id)
         XCTAssertEqual(g.package(for: fooDepTarget)?.id, fooPackage.id)
         let barPackage = try XCTUnwrap(g.package(for: .plain("Bar")))
-        let barTarget = try XCTUnwrap(g.allTargets.first{ $0.name == "Bar" })
+        let barTarget = try XCTUnwrap(g.target(for: "Bar"))
         XCTAssertEqual(g.package(for: barTarget)?.id, barPackage.id)
     }
 

Tests/SourceKitLSPAPITests/SourceKitLSPAPITests.swift

@@ -87,7 +87,7 @@ extension SourceKitLSPAPI.BuildDescription {
         partialArguments: [String],
         isPartOfRootPackage: Bool
     ) throws -> Bool {
-        let target = try XCTUnwrap(graph.allTargets.first(where: { $0.name == targetName }))
+        let target = try XCTUnwrap(graph.target(for: targetName))
         let buildTarget = try XCTUnwrap(self.getBuildTarget(for: target, in: graph))
 
         guard let file = buildTarget.sources.first else {