Tests: adjust windows librarian test slightly (#6450)

compnerd · web-flow · commit 8f9556fb8a33 · 2023-04-18T12:11:23.000-07:00
Use the unsuffixed version of the tool's spelling.  Although we should
accept the suffixed variant (which `clang` does do!) the lookup in SPM
currently does not properly handle the path lookup with that.
diff --git a/Tests/PackageModelTests/PackageModelTests.swift b/Tests/PackageModelTests/PackageModelTests.swift
@@ -124,7 +124,7 @@ class PackageModelTests: XCTestCase {
                 try XCTAssertEqual(
                     UserToolchain.determineLibrarian(
                         triple: triple, binDirectories: [bin], useXcrun: false, environment: [:], searchPaths: [],
-                        extraSwiftFlags: ["-Xswiftc", "-use-ld=not-link\(suffix)"]
+                        extraSwiftFlags: ["-Xswiftc", "-use-ld=not-link"]
                     ),
                     not
                 )

Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ class PackageModelTests: XCTestCase {`
`124`	`124`	`try XCTAssertEqual(`
`125`	`125`	`UserToolchain.determineLibrarian(`
`126`	`126`	`triple: triple, binDirectories: [bin], useXcrun: false, environment: [:], searchPaths: [],`
`127`		`- extraSwiftFlags: ["-Xswiftc", "-use-ld=not-link\(suffix)"]`
	`127`	`+ extraSwiftFlags: ["-Xswiftc", "-use-ld=not-link"]`
`128`	`128`	`),`
`129`	`129`	`not`
`130`	`130`	`)`