[Tests] Remove now unnecessary deps on Utility.

Author: ddunbar

Package.swift

@@ -83,6 +83,7 @@ let package = Package(
             dependencies: ["Basic", "PackageGraph"]),
 
         // MARK: Commands
+        
         Target(
             /** High-level commands */
             name: "Commands",
@@ -103,17 +104,12 @@ let package = Package(
             /** Shim tool to find test names on OS X */
             name: "swiftpm-xctest-helper",
             dependencies: []),
-        Target(
-            /** FIXME: The Basic tests currently have a layering violation and a dependency on Utility for infrastructure. */
-            name: "BasicTests",
-            dependencies: ["Basic", "Utility"]),
+
+        // MARK: Additional Test Dependencies
+        
         Target(
             name: "FunctionalTests",
             dependencies: ["Basic", "Utility", "PackageModel"]),
-        Target(
-            /** FIXME: Turns out PackageLoadingTests violate encapsulation :( */
-            name: "PackageLoadingTests",
-            dependencies: ["Get", "PackageLoading"]),
     ])
 
 

Tests/BasicTests/FileSystemTests.swift

@@ -12,7 +12,6 @@ import XCTest
 
 import Basic
 import POSIX
-import Utility
 
 func XCTAssertThrows<T: Swift.Error>(_ expectedError: T, file: StaticString = #file, line: UInt = #line, _ body: () throws -> ()) where T: Equatable {
     do {

Tests/BasicTests/PathShimTests.swift

@@ -13,7 +13,6 @@ import XCTest
 
 import Basic
 import POSIX
-import Utility
 
 class PathShimTests : XCTestCase {
 

Tests/BasicTests/PathTests.swift

@@ -9,10 +9,9 @@
 */
 
 import XCTest
-import POSIX
-import Basic
-import Utility
 
+import Basic
+import POSIX
 
 class PathTests: XCTestCase {
 

Tests/BasicTests/SynchronizedQueueTests.swift

@@ -12,7 +12,6 @@ import Foundation
 import XCTest
 
 import Basic
-import Utility
 
 class SyncronizedQueueTests: XCTestCase {
 

Tests/BasicTests/TemporaryFileTests.swift

@@ -9,10 +9,11 @@
 */
 
 import XCTest
-import Utility
-import Basic
+
 import class Foundation.FileManager
 
+import Basic
+
 class TemporaryFileTests: XCTestCase {
     func testBasicReadWrite() throws {
         let filePath: AbsolutePath

Tests/BasicTests/ThreadTests.swift

@@ -11,7 +11,6 @@
 import XCTest
 
 import Basic
-import Utility
 
 typealias Thread = Basic.Thread