Fix an XCBuild compatibility issue (#6753)

neonichu · web-flow · commit 9be12c545db2 · 2023-07-28T11:14:44.000-07:00
Some newer versions of XCBuild require a new build setting for opting into generation of the resource accessor. rdar://112991922 (cherry picked from commit 6478e27)
diff --git a/Sources/XCBuildSupport/PIF.swift b/Sources/XCBuildSupport/PIF.swift
@@ -957,6 +957,7 @@ public enum PIF {
             case MARKETING_VERSION
             case CURRENT_PROJECT_VERSION
             case SWIFT_EMIT_MODULE_INTERFACE
+            case GENERATE_RESOURCE_ACCESSORS
         }
 
         public enum MultipleValueSetting: String, Codable {
diff --git a/Sources/XCBuildSupport/PIFBuilder.swift b/Sources/XCBuildSupport/PIFBuilder.swift
@@ -464,6 +464,7 @@ final class PackagePIFProjectBuilder: PIFProjectBuilder {
 
         if let resourceBundle = addResourceBundle(for: mainTarget, in: pifTarget) {
             settings[.PACKAGE_RESOURCE_BUNDLE_NAME] = resourceBundle
+            settings[.GENERATE_RESOURCE_ACCESSORS] = "YES"
         }
 
         // For targets, we use the common build settings for both the "Debug" and the "Release" configurations (all

Original file line number	Diff line number	Diff line change
`@@ -957,6 +957,7 @@ public enum PIF {`
`957`	`957`	`case MARKETING_VERSION`
`958`	`958`	`case CURRENT_PROJECT_VERSION`
`959`	`959`	`case SWIFT_EMIT_MODULE_INTERFACE`
	`960`	`+ case GENERATE_RESOURCE_ACCESSORS`
`960`	`961`	`}`
`961`	`962`
`962`	`963`	`public enum MultipleValueSetting: String, Codable {`
Original file line number	Diff line number	Diff line change
`@@ -464,6 +464,7 @@ final class PackagePIFProjectBuilder: PIFProjectBuilder {`
`464`	`464`
`465`	`465`	`if let resourceBundle = addResourceBundle(for: mainTarget, in: pifTarget) {`
`466`	`466`	`settings[.PACKAGE_RESOURCE_BUNDLE_NAME] = resourceBundle`
	`467`	`+ settings[.GENERATE_RESOURCE_ACCESSORS] = "YES"`
`467`	`468`	`}`
`468`	`469`
`469`	`470`	`// For targets, we use the common build settings for both the "Debug" and the "Release" configurations (all`