Refactor DestinationCommand.ListDestinations

Author: MaxDesiatov

Sources/Commands/DestinationTools/ListDestinations.swift

@@ -65,50 +65,64 @@ extension DestinationCommand {
                         rootPath: bundlePath
                     )
 
-                    for (artifactID, artifactMetadata) in parsedManifest.artifacts
-                    where artifactMetadata.type == .crossCompilationDestination {
-                        for variant in artifactMetadata.variants {
-                            let destinationJSONPath = try bundlePath
-                                .appending(RelativePath(validating: variant.path))
-                                .appending(component: "destination.json")
+                    try parsedManifest.printValidatedArtifactIDs(
+                        bundlePath: bundlePath,
+                        fileSystem: fileSystem,
+                        observabilityScope: observabilityScope
+                    )
+                } catch {
+                    observabilityScope.emit(
+                        .warning(
+                            "Couldn't parse `info.json` manifest of a destination bundle at \(bundlePath): \(error)"
+                        )
+                    )
+                }
+            }
+        }
+    }
+}
 
-                            guard fileSystem.exists(destinationJSONPath) else {
-                                observabilityScope.emit(
-                                    .warning(
-                                        """
-                                        Destination metadata file not found at \(
-                                            destinationJSONPath
-                                        ) for a variant of artifact \(artifactID)
-                                        """
-                                    )
-                                )
+private extension ArtifactsArchiveMetadata {
+    func printValidatedArtifactIDs(
+        bundlePath: AbsolutePath,
+        fileSystem: FileSystem,
+        observabilityScope: ObservabilityScope
+    ) throws {
+        for (artifactID, artifactMetadata) in artifacts
+        where artifactMetadata.type == .crossCompilationDestination {
+            for variant in artifactMetadata.variants {
+                let destinationJSONPath = try bundlePath
+                    .appending(RelativePath(validating: variant.path))
+                    .appending(component: "destination.json")
 
-                                continue
-                            }
+                guard fileSystem.exists(destinationJSONPath) else {
+                    observabilityScope.emit(
+                        .warning(
+                            """
+                            Destination metadata file not found at \(
+                                destinationJSONPath
+                            ) for a variant of artifact \(artifactID)
+                            """
+                        )
+                    )
 
-                            do {
-                                _ = try Destination(
-                                    fromFile: destinationJSONPath, fileSystem: fileSystem
-                                )
-                            } catch {
-                                observabilityScope.emit(
-                                    .warning(
-                                        "Couldn't parse destination metadata at \(destinationJSONPath): \(error)"
-                                    )
-                                )
-                            }
-                        }
+                    continue
+                }
 
-                        print(artifactID)
-                    }
+                do {
+                    _ = try Destination(
+                        fromFile: destinationJSONPath, fileSystem: fileSystem
+                    )
                 } catch {
                     observabilityScope.emit(
                         .warning(
-                            "Couldn't parse `info.json` manifest of a destination bundle at \(bundlePath): \(error)"
+                            "Couldn't parse destination metadata at \(destinationJSONPath): \(error)"
                         )
                     )
                 }
             }
+
+            print(artifactID)
         }
     }
 }