Merge pull request #2880 from keith/ks/allow-empty-build-settings-arrays

Allow empty build settings arrays

Author: abertelrud

Sources/PackageLoading/PackageDescription4Loader.swift

@@ -172,12 +172,7 @@ extension ManifestBuilder {
     }
 
     func parseBuildSettings(_ json: JSON, tool: TargetBuildSettingDescription.Tool, settingName: String) throws -> [TargetBuildSettingDescription.Setting] {
-
         let declaredSettings = try json.getArray()
-        if declaredSettings.isEmpty {
-            throw ManifestParseError.runtimeManifestErrors(["\(settingName) cannot be an empty array; provide at least one setting or remove it"])
-        }
-
         return try declaredSettings.map({
             try parseBuildSetting($0, tool: tool)
         })

Tests/PackageLoadingTests/PD5LoadingTests.swift

@@ -431,12 +431,7 @@ class PackageDescription5LoadingTests: PackageDescriptionLoadingTests {
             )
             """
 
-        do {
-            try loadManifestThrowing(stream.bytes) { _ in }
-            XCTFail("Unexpected success")
-        } catch ManifestParseError.runtimeManifestErrors(let errors) {
-            XCTAssertEqual(errors, ["cSettings cannot be an empty array; provide at least one setting or remove it"])
-        }
+        try loadManifestThrowing(stream.bytes) { _ in }
     }
 
     func testWindowsPlatform() throws {