Tests: simplify constant construction (#6461)

compnerd · web-flow · commit bd506b733d05 · 2023-04-20T10:14:26.000-07:00
Reuse the base path from a local variable reducing the arcs that we
append to reduce the amount of duplication and avoid having multiple
sites to modify for changes.
diff --git a/Tests/WorkspaceTests/WorkspaceTests.swift b/Tests/WorkspaceTests/WorkspaceTests.swift
@@ -244,7 +244,7 @@ final class WorkspaceTests: XCTestCase {
             testDiagnostics(observability.diagnostics) { result in
                 let diagnostic = result.check(
                     diagnostic: .contains(
-                        "\(path.appending(components: "MyPkg", "Package.swift")):4:8: error: An error in MyPkg"
+                        "\(pkgDir.appending("Package.swift")):4:8: error: An error in MyPkg"
                     ),
                     severity: .error
                 )

Original file line number	Diff line number	Diff line change
`@@ -244,7 +244,7 @@ final class WorkspaceTests: XCTestCase {`
`244`	`244`	`testDiagnostics(observability.diagnostics) { result in`
`245`	`245`	`let diagnostic = result.check(`
`246`	`246`	`diagnostic: .contains(`
`247`		`- "\(path.appending(components: "MyPkg", "Package.swift")):4:8: error: An error in MyPkg"`
	`247`	`+ "\(pkgDir.appending("Package.swift")):4:8: error: An error in MyPkg"`
`248`	`248`	`),`
`249`	`249`	`severity: .error`
`250`	`250`	`)`