Modify isGitIgnored to be able to process multiple paths in one invocation

This way there is no need to create the shell process for every path separately which can improve the performance

Author: ViktorSimko

Sources/SourceControl/GitRepository.swift

@@ -398,18 +398,19 @@ public class GitRepository: Repository, WorkingCheckout {
     }
 
     /// Returns true if the file at `path` is ignored by `git`
-    public func isIgnored(_ path: AbsolutePath) throws -> Bool {
+    public func isGitIgnored(_ paths: [AbsolutePath]) throws -> [Bool] {
         return try queue.sync {
-            let result = try Process.popen(args: Git.tool, "-C", self.path.asString, "check-ignore", path.asString)
+            let stringPaths = paths.map({ $0.asString })
+            let args = [Git.tool, "-C", self.path.asString, "check-ignore"] + stringPaths
+            let result = try Process.popen(arguments: args)
 
-            switch result.exitStatus {
-            case .terminated(code: 0):
-                return true
-            case .terminated(code: 1):
-                return false
-            default:
+            guard result.exitStatus == .terminated(code: 0) || result.exitStatus == .terminated(code: 1) else {
                 throw GitInterfaceError.fatalError
             }
+
+            let output = try result.utf8Output()
+
+            return stringPaths.map(output.contains)
         }
     }
 

Sources/SourceControl/InMemoryGitRepository.swift

@@ -273,8 +273,8 @@ extension InMemoryGitRepository: WorkingCheckout {
         return true
     }
 
-    public func isIgnored(_ path: AbsolutePath) throws -> Bool {
-        return false
+    public func isGitIgnored(_ paths: [AbsolutePath]) throws -> [Bool] {
+        return [false]
     }
 }
 

Sources/SourceControl/Repository.swift

@@ -198,7 +198,7 @@ public protocol WorkingCheckout {
     func isAlternateObjectStoreValid() -> Bool
 
     /// Returns true if the file at `path` is ignored by `git`
-    func isIgnored(_ path: AbsolutePath) throws -> Bool
+    func isGitIgnored(_ paths: [AbsolutePath]) throws -> [Bool]
 }
 
 /// A single repository revision.

Tests/SourceControlTests/GitRepositoryTests.swift

@@ -605,7 +605,7 @@ class GitRepositoryTests: XCTestCase {
         }
     }
 
-    func testIgnored() throws {
+    func testGitIgnored() throws {
         mktmpdir { path in
             // Create a repo.
             let testRepoPath = path.appending(component: "test-repo")
@@ -614,10 +614,15 @@ class GitRepositoryTests: XCTestCase {
             let repo = GitRepository(path: testRepoPath)
 
             // Add a .gitignore
-            try localFileSystem.writeFileContents(testRepoPath.appending(component: ".gitignore"), bytes: "ignored_file")
+            try localFileSystem.writeFileContents(testRepoPath.appending(component: ".gitignore"), bytes: "ignored_file1\nignored_file2")
 
-            XCTAssertTrue(try repo.isIgnored(testRepoPath.appending(component: "ignored_file")))
-            XCTAssertFalse(try repo.isIgnored(testRepoPath.appending(component: "not_ignored_file")))
+            let ignored = try repo.isGitIgnored([testRepoPath.appending(component: "ignored_file1"), testRepoPath.appending(component: "ignored_file2"), testRepoPath.appending(component: "not_ignored")])
+            XCTAssertTrue(ignored[0])
+            XCTAssertTrue(ignored[1])
+            XCTAssertFalse(ignored[2])
+
+            let notIgnored = try repo.isGitIgnored([testRepoPath.appending(component: "not_ignored")])
+            XCTAssertFalse(notIgnored[0])
         }
     }
 
@@ -637,6 +642,6 @@ class GitRepositoryTests: XCTestCase {
         ("testSubmodules", testSubmodules),
         ("testUncommitedChanges", testUncommitedChanges),
         ("testAlternativeObjectStoreValidation", testAlternativeObjectStoreValidation),
-        ("testIgnored", testIgnored),
+        ("testGitIgnored", testGitIgnored),
     ]
 }