Reduce usage of callback and dispatch methods in favor of async/await

Remove unused callback API
Remove unneeded withChecked*Continuation wrappers
Use async/await in more tests
Remove a usage of DispatchGroup in tests
Remove unused callback queues from async methods
Removed unused callback methods
Moved workspace and plugins to async/await

Author: AndrewHoos

Sources/Build/BuildOperation.swift

@@ -566,7 +566,6 @@ public final class BuildOperation: PackageStructureDelegate, SPMBuildCore.BuildS
             pluginName: plugin.moduleName,
             toolsVersion: plugin.toolsVersion,
             observabilityScope: self.observabilityScope,
-            callbackQueue: DispatchQueue.sharedConcurrent,
             delegate: delegate
         )
 

Sources/Commands/PackageCommands/PluginCommand.swift

@@ -394,7 +394,6 @@ struct PluginCommand: AsyncSwiftCommand {
             fileSystem: swiftCommandState.fileSystem,
             modulesGraph: packageGraph,
             observabilityScope: swiftCommandState.observabilityScope,
-            callbackQueue: delegateQueue,
             delegate: pluginDelegate
         )
 

Sources/PackageRegistry/ChecksumTOFU.swift

@@ -67,29 +67,6 @@ struct PackageVersionChecksumTOFU {
         }
     }
 
-    @available(*, noasync, message: "Use the async alternative")
-    func validateSourceArchive(
-        registry: Registry,
-        package: PackageIdentity.RegistryIdentity,
-        version: Version,
-        checksum: String,
-        timeout: DispatchTimeInterval?,
-        observabilityScope: ObservabilityScope,
-        callbackQueue: DispatchQueue,
-        completion: @escaping @Sendable (Result<Void, Error>) -> Void
-    ) {
-        callbackQueue.asyncResult(completion) {
-            try await self.validateSourceArchive(
-                registry: registry,
-                package: package,
-                version: version,
-                checksum: checksum,
-                timeout: timeout,
-                observabilityScope: observabilityScope
-            )
-        }
-    }
-
     private func getExpectedChecksum(
         registry: Registry,
         package: PackageIdentity.RegistryIdentity,

Sources/PackageRegistry/RegistryClient.swift

@@ -613,25 +613,6 @@ public final class RegistryClient: AsyncCancellable {
         }
     }
 
-    @available(*, deprecated, message: "Use the async alternative")
-    public func getAvailableManifests(
-        package: PackageIdentity,
-        version: Version,
-        timeout: DispatchTimeInterval? = .none,
-        observabilityScope: ObservabilityScope,
-        callbackQueue: DispatchQueue,
-        completion: @escaping @Sendable (Result<[String: (toolsVersion: ToolsVersion, content: String?)], Error>) -> Void
-    ) {
-        callbackQueue.asyncResult(completion) {
-            try await self.getAvailableManifests(
-                package: package,
-                version: version,
-                timeout: timeout,
-                observabilityScope: observabilityScope
-            )
-        }
-    }
-
     public func getManifestContent(
         package: PackageIdentity,
         version: Version,

Sources/PackageRegistry/RegistryDownloadsManager.swift

@@ -119,23 +119,6 @@ public class RegistryDownloadsManager: AsyncCancellable {
         return try await task.value
     }
 
-    @available(*, noasync, message: "Use the async alternative")
-    public func lookup(
-        package: PackageIdentity,
-        version: Version,
-        observabilityScope: ObservabilityScope,
-        callbackQueue: DispatchQueue,
-        completion: @escaping @Sendable (Result<Basics.AbsolutePath, Error>) -> Void
-    ) {
-        callbackQueue.asyncResult(completion) {
-            try await self.lookup(
-                package: package,
-                version: version,
-                observabilityScope: observabilityScope
-            )
-        }
-    }
-
     /// Cancel any outstanding requests
     public func cancel(deadline: DispatchTime) async throws {
         try await self.registryClient.cancel(deadline: deadline)

Sources/PackageRegistry/SignatureValidation.swift

@@ -94,33 +94,6 @@ struct SignatureValidation {
         return signingEntity;
     }
 
-    @available(*, noasync, message: "Use the async alternative")
-    func validate(
-        registry: Registry,
-        package: PackageIdentity.RegistryIdentity,
-        version: Version,
-        content: Data,
-        configuration: RegistryConfiguration.Security.Signing,
-        timeout: DispatchTimeInterval?,
-        fileSystem: FileSystem,
-        observabilityScope: ObservabilityScope,
-        callbackQueue: DispatchQueue,
-        completion: @escaping @Sendable (Result<SigningEntity?, Error>) -> Void
-    ) {
-        callbackQueue.asyncResult(completion) {
-            try await self.validate(
-                registry: registry,
-                package: package,
-                version: version,
-                content: content,
-                configuration: configuration,
-                timeout: timeout,
-                fileSystem: fileSystem,
-                observabilityScope: observabilityScope
-            )
-        }
-    }
-
     private func getAndValidateSourceArchiveSignature(
         registry: Registry,
         package: PackageIdentity.RegistryIdentity,
@@ -350,36 +323,6 @@ struct SignatureValidation {
         return signingEntity;
     }
 
-
-    @available(*, noasync, message: "Use the async alternative")
-    func validate(
-        registry: Registry,
-        package: PackageIdentity.RegistryIdentity,
-        version: Version,
-        toolsVersion: ToolsVersion?,
-        manifestContent: String,
-        configuration: RegistryConfiguration.Security.Signing,
-        timeout: DispatchTimeInterval?,
-        fileSystem: FileSystem,
-        observabilityScope: ObservabilityScope,
-        callbackQueue: DispatchQueue,
-        completion: @escaping @Sendable (Result<SigningEntity?, Error>) -> Void
-    ) {
-        callbackQueue.asyncResult(completion) {
-            try await self.validate(
-                registry: registry,
-                package: package,
-                version: version,
-                toolsVersion: toolsVersion,
-                manifestContent: manifestContent,
-                configuration: configuration,
-                timeout: timeout,
-                fileSystem: fileSystem,
-                observabilityScope: observabilityScope
-            )
-        }
-    }
-
     private func getAndValidateManifestSignature(
         registry: Registry,
         package: PackageIdentity.RegistryIdentity,

Sources/PackageRegistry/SigningEntityTOFU.swift

@@ -76,26 +76,6 @@ struct PackageSigningEntityTOFU {
         )
     }
 
-    @available(*, noasync, message: "Use the async alternative")
-    func validate(
-        registry: Registry,
-        package: PackageIdentity.RegistryIdentity,
-        version: Version,
-        signingEntity: SigningEntity?,
-        observabilityScope: ObservabilityScope,
-        completion: @escaping @Sendable (Result<Void, Error>) -> Void
-    ) {
-        DispatchQueue.sharedConcurrent.asyncResult(completion) {
-            try await self.validate(
-                registry: registry,
-                package: package,
-                version: version,
-                signingEntity: signingEntity,
-                observabilityScope: observabilityScope
-            )
-        }
-    }
-
     private func validateSigningEntity(
         registry: Registry,
         package: PackageIdentity.RegistryIdentity,