Skip to content

Commit c1af525

Browse files
committed
Unskip tests blocked by requireThreadSafeWorkingDirectory
Now that llbuild has fork/exec support, the tests can be enabled on Amazon Linux 2, OpenBSD, etc. Closes #8499
1 parent 609592e commit c1af525

File tree

3 files changed

+0
-12
lines changed

3 files changed

+0
-12
lines changed

Tests/BuildTests/BuildPlanTests.swift

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7466,14 +7466,7 @@ class BuildPlanSwiftBuildTests: BuildPlanTestCase {
74667466
}
74677467

74687468
override func testPackageNameFlag() async throws {
7469-
try XCTSkipIfWorkingDirectoryUnsupported()
74707469
try XCTSkipOnWindows(because: "Skip until there is a resolution to the partial linking with Windows that results in a 'subsystem must be defined' error.")
7471-
#if os(Linux)
7472-
// Linking error: "/usr/bin/ld.gold: fatal error: -pie and -static are incompatible".
7473-
// Tracked by GitHub issue: https://github.com/swiftlang/swift-package-manager/issues/8499
7474-
throw XCTSkip("Skipping Swift Build testing on Linux because of linking issues.")
7475-
#endif
7476-
74777470
try await super.testPackageNameFlag()
74787471
}
74797472

Tests/CommandsTests/BuildCommandTests.swift

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -856,7 +856,6 @@ class BuildCommandSwiftBuildTests: BuildCommandTestCases {
856856
}
857857

858858
override func testParseableInterfaces() async throws {
859-
try XCTSkipIfWorkingDirectoryUnsupported()
860859
try XCTSkipOnWindows(because: "possible long filename issue: needs investigation")
861860

862861
try await fixture(name: "Miscellaneous/ParseableInterfaces") { fixturePath in
@@ -939,13 +938,11 @@ class BuildCommandSwiftBuildTests: BuildCommandTestCases {
939938

940939
override func testBuildSystemDefaultSettings() async throws {
941940
try XCTSkipOnWindows(because: "possible long filename issue: needs investigation")
942-
try XCTSkipIfWorkingDirectoryUnsupported()
943941

944942
try await super.testBuildSystemDefaultSettings()
945943
}
946944

947945
override func testBuildCompleteMessage() async throws {
948-
try XCTSkipIfWorkingDirectoryUnsupported()
949946
try XCTSkipOnWindows(because: "possible long filename issue: needs investigation")
950947

951948
try await super.testBuildCompleteMessage()

Tests/CommandsTests/PackageCommandTests.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4084,8 +4084,6 @@ class PackageCommandSwiftBuildTests: PackageCommandTestCase {
40844084
override func testCommandPluginTestingCallbacks() async throws {
40854085
throw XCTSkip("SWBINTTODO: Requires PIF generation to adopt new test runner product type")
40864086
try XCTSkipOnWindows(because: "TSCBasic/Path.swift:969: Assertion failed, https://github.com/swiftlang/swift-package-manager/issues/8602")
4087-
try XCTSkipIfWorkingDirectoryUnsupported()
4088-
40894087
try await super.testCommandPluginTestingCallbacks()
40904088
}
40914089

0 commit comments

Comments
 (0)