Skip to content

Commit c6fcbea

Browse files
committed
Add dependency equality test in TargetTests
1 parent 5ecf03d commit c6fcbea

File tree

1 file changed

+9
-22
lines changed

1 file changed

+9
-22
lines changed

Tests/PackageGraphTests/TargetTests.swift

Lines changed: 9 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import PackageGraph
1616
import PackageModel
1717

1818
private extension ResolvedTarget {
19-
init(name: String, deps: ResolvedTarget...) {
19+
init(name: String, deps: ResolvedTarget..., conditions: [PackageCondition] = []) {
2020
self.init(
2121
underlying: SwiftTarget(
2222
name: name,
@@ -36,29 +36,17 @@ private extension ResolvedTarget {
3636
}
3737
}
3838

39-
func testTargets(file: StaticString = #file, line: UInt = #line, body: () throws -> Void) {
40-
do {
41-
try body()
42-
} catch {
43-
XCTFail("\(error)", file: file, line: line)
44-
}
45-
}
46-
4739
class TargetDependencyTests: XCTestCase {
48-
4940
func test1() throws {
50-
testTargets {
5141
let t1 = ResolvedTarget(name: "t1")
5242
let t2 = ResolvedTarget(name: "t2", deps: t1)
5343
let t3 = ResolvedTarget(name: "t3", deps: t2)
5444

5545
XCTAssertEqual(try t3.recursiveTargetDependencies(), [t2, t1])
5646
XCTAssertEqual(try t2.recursiveTargetDependencies(), [t1])
57-
}
5847
}
5948

6049
func test2() throws {
61-
testTargets {
6250
let t1 = ResolvedTarget(name: "t1")
6351
let t2 = ResolvedTarget(name: "t2", deps: t1)
6452
let t3 = ResolvedTarget(name: "t3", deps: t2, t1)
@@ -67,11 +55,9 @@ class TargetDependencyTests: XCTestCase {
6755
XCTAssertEqual(try t4.recursiveTargetDependencies(), [t3, t2, t1])
6856
XCTAssertEqual(try t3.recursiveTargetDependencies(), [t2, t1])
6957
XCTAssertEqual(try t2.recursiveTargetDependencies(), [t1])
70-
}
7158
}
7259

7360
func test3() throws {
74-
testTargets {
7561
let t1 = ResolvedTarget(name: "t1")
7662
let t2 = ResolvedTarget(name: "t2", deps: t1)
7763
let t3 = ResolvedTarget(name: "t3", deps: t2, t1)
@@ -80,11 +66,9 @@ class TargetDependencyTests: XCTestCase {
8066
XCTAssertEqual(try t4.recursiveTargetDependencies(), [t3, t2, t1])
8167
XCTAssertEqual(try t3.recursiveTargetDependencies(), [t2, t1])
8268
XCTAssertEqual(try t2.recursiveTargetDependencies(), [t1])
83-
}
8469
}
8570

8671
func test4() throws {
87-
testTargets {
8872
let t1 = ResolvedTarget(name: "t1")
8973
let t2 = ResolvedTarget(name: "t2", deps: t1)
9074
let t3 = ResolvedTarget(name: "t3", deps: t2)
@@ -93,11 +77,9 @@ class TargetDependencyTests: XCTestCase {
9377
XCTAssertEqual(try t4.recursiveTargetDependencies(), [t3, t2, t1])
9478
XCTAssertEqual(try t3.recursiveTargetDependencies(), [t2, t1])
9579
XCTAssertEqual(try t2.recursiveTargetDependencies(), [t1])
96-
}
9780
}
9881

9982
func test5() throws {
100-
testTargets {
10183
let t1 = ResolvedTarget(name: "t1")
10284
let t2 = ResolvedTarget(name: "t2", deps: t1)
10385
let t3 = ResolvedTarget(name: "t3", deps: t2)
@@ -117,11 +99,9 @@ class TargetDependencyTests: XCTestCase {
11799
XCTAssertEqual(try t4.recursiveTargetDependencies(), [t3, t2, t1])
118100
XCTAssertEqual(try t3.recursiveTargetDependencies(), [t2, t1])
119101
XCTAssertEqual(try t2.recursiveTargetDependencies(), [t1])
120-
}
121102
}
122103

123104
func test6() throws {
124-
testTargets {
125105
let t1 = ResolvedTarget(name: "t1")
126106
let t2 = ResolvedTarget(name: "t2", deps: t1)
127107
let t3 = ResolvedTarget(name: "t3", deps: t2)
@@ -141,6 +121,13 @@ class TargetDependencyTests: XCTestCase {
141121
XCTAssertEqual(try t4.recursiveTargetDependencies(), [t3, t2, t1])
142122
XCTAssertEqual(try t3.recursiveTargetDependencies(), [t2, t1])
143123
XCTAssertEqual(try t2.recursiveTargetDependencies(), [t1])
144-
}
124+
}
125+
126+
func testConditions() throws {
127+
let t1 = ResolvedTarget(name: "t1")
128+
let t2 = ResolvedTarget(name: "t2", deps: t1)
129+
let t2Conditions = ResolvedTarget(name: "t2", deps: t1, conditions: [.init(platforms: [.linux])])
130+
131+
XCTAssertEqual(t2, t2Conditions)
145132
}
146133
}

0 commit comments

Comments
 (0)