Add basic pkgconfig parser test

Author: aciidgh

Sources/Build/PkgConfig.swift

@@ -61,7 +61,7 @@ struct PkgConfig {
         return []
     }
 
-    private static func locatePCFile(name: String) throws -> String {
+    static func locatePCFile(name: String) throws -> String {
         for path in (searchPaths + envSearchPaths) {
             let pcFile = Path.join(path, "\(name).pc")
             if pcFile.isFile {
@@ -72,14 +72,15 @@ struct PkgConfig {
     }
 }
 
-private struct PkgConfigParser {
-    let pcFile: String
-    var variables = [String: String]()
+struct PkgConfigParser {
+    private let pcFile: String
+    private(set) var variables = [String: String]()
     var dependencies = [String]()
     var cFlags = ""
     var libs = ""
 
     init(pcFile: String) {
+        precondition(pcFile.isFile)
         self.pcFile = pcFile
     }
 
@@ -101,7 +102,7 @@ private struct PkgConfigParser {
         }
     }
 
-    func parseDependencies(_ depString: String) -> [String] {
+    private func parseDependencies(_ depString: String) -> [String] {
         let exploded = depString.characters.split(separator: " ").map(String.init)
         let operators = ["=", "<", ">", "<=", ">="]
         var deps = [String]()
@@ -120,7 +121,7 @@ private struct PkgConfigParser {
         return deps
     }
 
-    func resolveVariables(_ line: String) -> String {
+    private func resolveVariables(_ line: String) -> String {
         func resolve(_ string: String) -> String {
             var resolvedString = string
             guard let dollar = resolvedString.characters.index(of: "$") else { return string }
@@ -137,7 +138,7 @@ private struct PkgConfigParser {
         return resolved
     }
 
-    func value(line: String) -> String {
+    private func value(line: String) -> String {
         guard let colonIndex = line.characters.index(of: ":") else {
             return ""
         }

Tests/Build/PkgConfigParserTests.swift

@@ -0,0 +1,43 @@
+/*
+ This source file is part of the Swift.org open source project
+ 
+ Copyright 2015 - 2016 Apple Inc. and the Swift project authors
+ Licensed under Apache License v2.0 with Runtime Library Exception
+ 
+ See http://swift.org/LICENSE.txt for license information
+ See http://swift.org/CONTRIBUTORS.txt for Swift project authors
+*/
+
+@testable import Build
+@testable import Utility
+import XCTest
+
+final class PkgConfigParserTests: XCTestCase {
+    
+    func testGTK3PCFile() {
+        loadPCFile("gtk+-3.0.pc") { parser in
+            XCTAssertEqual(parser.variables, ["libdir": "/usr/local/Cellar/gtk+3/3.18.9/lib", "gtk_host": "x86_64-apple-darwin15.3.0", "includedir": "/usr/local/Cellar/gtk+3/3.18.9/include", "prefix": "/usr/local/Cellar/gtk+3/3.18.9", "gtk_binary_version": "3.0.0", "exec_prefix": "/usr/local/Cellar/gtk+3/3.18.9", "targets": "quartz"])
+            XCTAssertEqual(parser.dependencies, ["gdk-3.0", "atk", "cairo", "cairo-gobject", "gdk-pixbuf-2.0", "gio-2.0"])
+            XCTAssertEqual(parser.cFlags, "-I/usr/local/Cellar/gtk+3/3.18.9/include/gtk-3.0 ")
+            XCTAssertEqual(parser.libs, "-L/usr/local/Cellar/gtk+3/3.18.9/lib -lgtk-3 ")
+        }
+    }
+    
+    private func loadPCFile(_ inputName: String, line: UInt = #line, body: (PkgConfigParser) -> Void) {
+        do {
+            let input = Path.join(#file, "../pkgconfigInputs", inputName).normpath
+            var parser = PkgConfigParser(pcFile: input)
+            try parser.parse()
+            body(parser)
+        } catch {
+            XCTFail("Unexpected error: \(error)", file: #file, line: line)
+        }
+    }
+}
+
+
+extension PkgConfigParserTests {
+    static var allTests : [(String, PkgConfigParserTests -> () throws -> Void)] {
+        return []
+    }
+}

Tests/Build/pkgconfigInputs/gtk+-3.0.pc

@@ -0,0 +1,16 @@
+prefix=/usr/local/Cellar/gtk+3/3.18.9
+exec_prefix=${prefix}
+libdir=${exec_prefix}/lib
+includedir=${prefix}/include
+targets=quartz
+
+gtk_binary_version=3.0.0
+gtk_host=x86_64-apple-darwin15.3.0
+
+Name: GTK+
+Description: GTK+ Graphical UI Library
+Version: 3.18.9
+Requires: gdk-3.0 atk >= 2.15.1 cairo >= 1.14.0 cairo-gobject >= 1.14.0 gdk-pixbuf-2.0 >= 2.30.0 gio-2.0 >= 2.45.8
+Requires.private: atk   epoxy >= 1.0 gio-unix-2.0 >= 2.45.8
+Libs: -L${libdir} -lgtk-3 
+Cflags: -I${includedir}/gtk-3.0