Skip to content

Commit d430b4b

Browse files
committed
[PackageGraph] Simplify duplicate target check
1 parent cf5a865 commit d430b4b

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

Sources/PackageGraph/PackageGraphLoader.swift

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -273,11 +273,8 @@ private func createResolvedPackages(
273273

274274
// Establish dependencies in each target.
275275
for targetBuilder in packageBuilder.targets {
276-
if allTargetNames.contains(targetBuilder.target.name) {
277-
foundDuplicateTarget = true
278-
}
279-
280-
allTargetNames.insert(targetBuilder.target.name)
276+
// Record if we see a duplicate target.
277+
foundDuplicateTarget = foundDuplicateTarget || !allTargetNames.insert(targetBuilder.target.name).inserted
281278

282279
// Directly add all the system module dependencies.
283280
targetBuilder.dependencies += implicitSystemTargetDeps

0 commit comments

Comments
 (0)