Create destination directory before writing archive

mattt · mattt · commit d5a6d687f95b · 2021-09-08T09:45:04.000-07:00
diff --git a/Sources/PackageRegistry/RegistryManager.swift b/Sources/PackageRegistry/RegistryManager.swift
@@ -247,11 +247,11 @@ public final class RegistryManager {
                             )
                         }
 
+                        try fileSystem.createDirectory(destinationPath, recursive: true)
+
                         let archivePath = destinationPath.withExtension("zip")
                         try fileSystem.writeFileContents(archivePath, bytes: contents)
 
-                        try fileSystem.createDirectory(destinationPath, recursive: true)
-
                         let archiver = Self.archiverFactory(fileSystem)
                         // TODO: Bail if archive contains relative paths or overlapping files
                         archiver.extract(from: archivePath, to: destinationPath) { result in

Original file line number	Diff line number	Diff line change
`@@ -247,11 +247,11 @@ public final class RegistryManager {`
`247`	`247`	`)`
`248`	`248`	`}`
`249`	`249`
	`250`	`+ try fileSystem.createDirectory(destinationPath, recursive: true)`
	`251`	`+`
`250`	`252`	`let archivePath = destinationPath.withExtension("zip")`
`251`	`253`	`try fileSystem.writeFileContents(archivePath, bytes: contents)`
`252`	`254`
`253`		`- try fileSystem.createDirectory(destinationPath, recursive: true)`
`254`		`-`
`255`	`255`	`let archiver = Self.archiverFactory(fileSystem)`
`256`	`256`	`// TODO: Bail if archive contains relative paths or overlapping files`
`257`	`257`	`archiver.extract(from: archivePath, to: destinationPath) { result in`