Skip to content

Commit e793e02

Browse files
authored
Remove outdated check for Ubuntu 14.04 and Clang 3.6 (#7012)
Swift no longer supports Ubuntu 14.04, the latest supported version is 18.04, so this check should no longer be needed.
1 parent 47b4fc5 commit e793e02

File tree

1 file changed

+0
-20
lines changed

1 file changed

+0
-20
lines changed

Sources/Commands/SwiftBuildTool.swift

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -122,12 +122,6 @@ public struct SwiftBuildTool: SwiftCommand {
122122
return
123123
}
124124

125-
#if os(Linux)
126-
// Emit warning if clang is older than version 3.6 on Linux.
127-
// See: <rdar://problem/28108951> SR-2299 Swift isn't using Gold by default on stock 14.04.
128-
checkClangVersion(observabilityScope: swiftTool.observabilityScope)
129-
#endif
130-
131125
guard let subset = options.buildSubset(observabilityScope: swiftTool.observabilityScope) else {
132126
throw ExitCode.failure
133127
}
@@ -144,20 +138,6 @@ public struct SwiftBuildTool: SwiftCommand {
144138
}
145139
}
146140

147-
private func checkClangVersion(observabilityScope: ObservabilityScope) {
148-
// We only care about this on Ubuntu 14.04
149-
guard let uname = try? TSCBasic.Process.checkNonZeroExit(args: "lsb_release", "-r").spm_chomp(),
150-
uname.hasSuffix("14.04"),
151-
let clangVersionOutput = try? TSCBasic.Process.checkNonZeroExit(args: "clang", "--version").spm_chomp(),
152-
let clang = getClangVersion(versionOutput: clangVersionOutput) else {
153-
return
154-
}
155-
156-
if clang < Version(3, 6, 0) {
157-
observabilityScope.emit(warning: "minimum recommended clang is version 3.6, otherwise you may encounter linker errors.")
158-
}
159-
}
160-
161141
public init() {}
162142
}
163143

0 commit comments

Comments
 (0)