[Traits] Enable all traits when building the symbol graph (#8177)

# Motivation

When building the symbol graph for documentation when want to make sure
all trait guarded code is build.

# Modification

This PR changes the trait configuration when extracting the symbol graph
by enabling all traits.

# Result

This PR will make sure all traits are enabled. In the future, we might
want to pass a trait configuration through the DocC plugin to SwiftPM
that allows us to build documentation with specific traits enabled but
for now this should be fine since a package should support enabling all
traits at once.

Author: FranzBusch

Fixtures/Traits/Package10/Package.swift

@@ -18,5 +18,11 @@ let package = Package(
         .target(
             name: "Package10Library1"
         ),
+        .plugin(
+            name: "SymbolGraphExtract",
+            capability: .command(
+                intent: .custom(verb: "extract", description: "")
+            )
+        ),
     ]
 )

Fixtures/Traits/Package10/Plugins/SymbolGraphExtract/Plugin.swift

@@ -0,0 +1,11 @@
+import PackagePlugin
+
+@main struct SymbolGraphExtractPlugin: CommandPlugin {
+    func performCommand(
+        context: PluginContext,
+        arguments: [String]
+    ) throws {
+        let result = try self.packageManager.getSymbolGraph(for: context.package.targets.first!, options: .init())
+        print(result.directoryPath)
+    }
+}

Fixtures/Traits/Package10/Sources/Package10Library1/Library.swift

@@ -10,3 +10,11 @@ public func hello() {
     print("Package10Library1 trait2 disabled")
     #endif
 }
+
+#if Package10Trait1
+public struct TypeGatedByPackage10Trait1 {}
+#endif
+
+#if Package10Trait2
+public struct TypeGatedByPackage10Trait2 {}
+#endif

Sources/Commands/Utilities/PluginDelegate.swift

@@ -16,6 +16,7 @@ import CoreCommands
 import Foundation
 import PackageModel
 import SPMBuildCore
+import PackageGraph
 
 import protocol TSCBasic.OutputByteStream
 import class TSCBasic.BufferedOutputByteStream
@@ -398,7 +399,7 @@ final class PluginDelegate: PluginInvocationDelegate {
         // Create a build system for building the target., skipping the the cache because we need the build plan.
         let buildSystem = try await swiftCommandState.createBuildSystem(
             explicitBuildSystem: .native,
-            traitConfiguration: .init(),
+            traitConfiguration: TraitConfiguration(enableAllTraits: true),
             cacheBuildManifest: false
         )
 

Tests/FunctionalTests/TraitTests.swift

@@ -238,5 +238,31 @@ final class TraitTests: XCTestCase {
             XCTAssertTrue(stdout.contains(expectedOut))
         }
     }
+
+    func testPackageDumpSymbolGraph_enablesAllTraits() async throws {
+        try await fixture(name: "Traits") { fixturePath in
+            let (stdout, _) = try await executeSwiftPackage(fixturePath.appending("Package10"), extraArgs: ["dump-symbol-graph"])
+            let optionalPath = stdout
+                .lazy
+                .split(whereSeparator: \.isNewline)
+                .first { String($0).hasPrefix("Files written to ") }?
+                .dropFirst(17)
+
+            let path = String(try XCTUnwrap(optionalPath))
+            let symbolGraph = try String(contentsOfFile: "\(path)/Package10Library1.symbols.json", encoding: .utf8)
+            XCTAssertTrue(symbolGraph.contains("TypeGatedByPackage10Trait1"))
+            XCTAssertTrue(symbolGraph.contains("TypeGatedByPackage10Trait2"))
+        }
+    }
+
+    func testPackagePluginGetSymbolGraph_enablesAllTraits() async throws {
+        try await fixture(name: "Traits") { fixturePath in
+            let (stdout, _) = try await executeSwiftPackage(fixturePath.appending("Package10"), extraArgs: ["plugin", "extract"])
+            let path = String(stdout.split(whereSeparator: \.isNewline).first!)
+            let symbolGraph = try String(contentsOfFile: "\(path)/Package10Library1.symbols.json", encoding: .utf8)
+            XCTAssertTrue(symbolGraph.contains("TypeGatedByPackage10Trait1"))
+            XCTAssertTrue(symbolGraph.contains("TypeGatedByPackage10Trait2"))
+        }
+    }
 }
 #endif