Skip to content

Commit eb5bd16

Browse files
committed
SourceControl: rename useBuiltinFSMonitor to fsmonitor
Git 2.36.0 renamed `useBuiltinFSMonitor` to `fsmonitor`. This configuration setting results in a warning. Given that Git 2.36.0 is now over a year old, rename the option we use to silence the warning. In the case of an installation of git predating the configuration renaming, we could run into issues with git opening the files preventing subsequent git operations, but in the general case, this should be equivalent.
1 parent 10f7922 commit eb5bd16

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

Sources/SourceControl/GitRepository.swift

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,10 +125,11 @@ public struct GitRepositoryProvider: RepositoryProvider, Cancellable {
125125
// FIXME: Ideally we should pass `--progress` here and report status regularly. We currently don't have callbacks for that.
126126
//
127127
// NOTE: Explicitly set `core.symlinks=true` on `git clone` to ensure that symbolic links are correctly resolved.
128-
// NOTE: Explicitly set `core.useBuiltinFSMonitor` on `git clone` to ensure that we do not spawn a monitor on the repository. This is particularly important for Windows where the process can prevent future operations.
128+
// NOTE: Explicitly set `core.fsmonitor` on `git clone` to ensure that we do not spawn a monitor on the repository. This is
129+
// particularly important for Windows where the process can prevent future operations.
129130
try self.callGit("clone",
130131
"-c", "core.symlinks=true",
131-
"-c", "core.useBuiltinFSMonitor=false",
132+
"-c", "core.fsmonitor=false",
132133
"--mirror", repository.location.gitURL, path.pathString,
133134
repository: repository,
134135
failureMessage: "Failed to clone repository \(repository.location)",

0 commit comments

Comments
 (0)