Skip to content

Commit eb74299

Browse files
committed
Refactor logic for getRegistriesConfig helper
1 parent d76923f commit eb74299

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

Sources/Commands/SwiftPackageRegistryTool.swift

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -153,17 +153,18 @@ public struct SwiftPackageRegistryTool: ParsableCommand {
153153

154154

155155
private extension SwiftTool {
156-
func getRegistriesConfig(sharedConfigurationDirectory: AbsolutePath? = nil) throws -> Workspace.Configuration.Registries {
157-
let sharedConfigurationDirectory = try sharedConfigurationDirectory ?? self.getSharedConfigurationDirectory()
158-
let sharedRegistriesFile = sharedConfigurationDirectory.map { Workspace.DefaultLocations.registriesConfigurationFile(at: $0) }
156+
func getRegistriesConfig() throws -> Workspace.Configuration.Registries {
157+
let localRegistriesFile = try Workspace.DefaultLocations.registriesConfigurationFile(at: self.getPackageRoot())
158+
159+
let workspace = try getActiveWorkspace()
160+
let sharedRegistriesFile = workspace.location.sharedConfigurationDirectory.map {
161+
Workspace.DefaultLocations.registriesConfigurationFile(at: $0)
162+
}
163+
159164
return try .init(
160-
localRegistriesFile: self.registriesConfigFile(),
165+
localRegistriesFile: localRegistriesFile,
161166
sharedRegistriesFile: sharedRegistriesFile,
162167
fileSystem: localFileSystem
163168
)
164169
}
165-
166-
func registriesConfigFile() throws -> AbsolutePath {
167-
try self.getPackageRoot().appending(components: ".swiftpm", "config", "registries.json")
168-
}
169170
}

Sources/Commands/SwiftTool.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -536,7 +536,7 @@ public class SwiftTool {
536536
return netrcFilePath
537537
}
538538

539-
func getSharedCacheDirectory() throws -> AbsolutePath? {
539+
private func getSharedCacheDirectory() throws -> AbsolutePath? {
540540
if let explicitCachePath = options.cachePath {
541541
// Create the explicit cache path if necessary
542542
if !localFileSystem.exists(explicitCachePath) {
@@ -553,7 +553,7 @@ public class SwiftTool {
553553
}
554554
}
555555

556-
func getSharedConfigurationDirectory() throws -> AbsolutePath? {
556+
private func getSharedConfigurationDirectory() throws -> AbsolutePath? {
557557
if let explicitConfigPath = options.configPath {
558558
// Create the explicit config path if necessary
559559
if !localFileSystem.exists(explicitConfigPath) {

0 commit comments

Comments
 (0)