cleanup

Author: tomerd

Sources/PackageGraph/PackageGraph+Loading.swift

@@ -55,7 +55,6 @@ extension PackageGraph {
             manifestMap[$0.identity]
         })
         let rootManifestNodes = root.packages.map { identity, package in
-            // FIXME: use PackageIdentity.root?
             GraphLoadingNode(identity: identity,
                              manifest: package.manifest,
                              productFilter: .everything)
@@ -273,7 +272,6 @@ private func createResolvedPackages(
                         dependencyLocation: dependencyLocation,
                         otherDependencyURL: resolvedPackage.package.manifest.packageLocation,
                         identity: dependencyIdentity)
-                    //let diagnosticLocation = PackageLocation.Local(name: package.name, packagePath: package.path)
                     return diagnostics.emit(error, location: package.diagnosticLocation)
                 }
                 // check that the explicit package dependency name matches the package name.
@@ -367,9 +365,6 @@ private func createResolvedPackages(
     for packageBuilder in packageBuilders {
         let package = packageBuilder.package
 
-        // The diagnostics location for this package.
-        //let diagnosticLocation = { PackageLocation.Local(name: package.name, packagePath: package.path) }
-
         // Get all implicit system library dependencies in this package.
         let implicitSystemTargetDeps = packageBuilder.dependencies
             .flatMap({ $0.targets })

Sources/Workspace/Workspace.swift

@@ -1098,7 +1098,8 @@ extension Workspace {
         func computePackageURLs() -> (required: Set<PackageReference>, missing: Set<PackageReference>) {
             let manifestsMap: [PackageIdentity: Manifest] = Dictionary(uniqueKeysWithValues:
                 self.root.packages.map { ($0.key, $0.value.manifest) } +
-                self.dependencies.map { ($0.dependency.packageIdentity, $0.manifest) }) // FIXME: use dependency identity
+                self.dependencies.map { ($0.dependency.packageIdentity, $0.manifest) }
+            )
 
             var inputIdentities: Set<PackageReference> = []
             let inputNodes: [GraphLoadingNode] = self.root.packages.map{ identity, package in