adjust FileSystem implementations to TSC API changes (#3962) (#3965)

motivation: TSC FileSystem API changed to add tempDirectory accessor

changes: add tempDirectory accessor in SwiftPM FileSystem implementations

rdar://86644116

Author: tomerd

Sources/Basics/VirtualFileSystem.swift

@@ -177,6 +177,8 @@ public class VirtualFileSystem: FileSystem {
 
     public var cachesDirectory: AbsolutePath? = nil
 
+    public var tempDirectory = AbsolutePath("/")
+
     public func createSymbolicLink(_ path: AbsolutePath, pointingAt destination: AbsolutePath, relative: Bool) throws {
         throw Errors.readOnlyFileSystem
     }

Sources/Commands/SwiftTool.swift

@@ -1035,8 +1035,8 @@ private func getSharedSecurityDirectory(options: SwiftToolOptions, observability
 
     do {
         let sharedSecurityDirectory = try localFileSystem.getOrCreateSwiftPMSecurityDirectory()
-        // And make sure we can write files (locking the directory writes a lock file)
-        try localFileSystem.withLock(on: sharedSecurityDirectory, type: .exclusive) { }
+        // make sure we can write files
+        try withTemporaryFile(dir: sharedSecurityDirectory) { _ in }
         return sharedSecurityDirectory
     } catch {
         observabilityScope.emit(warning: "Failed creating default security location, \(error)")
@@ -1054,7 +1054,10 @@ private func getSharedConfigurationDirectory(options: SwiftToolOptions, observab
     }
 
     do {
-        return try localFileSystem.getOrCreateSwiftPMConfigurationDirectory(observabilityScope: observabilityScope)
+        let sharedConfigurationDirector = try localFileSystem.getOrCreateSwiftPMConfigurationDirectory(observabilityScope: observabilityScope)
+        // make sure we can write files
+        try withTemporaryFile(dir: sharedConfigurationDirector) { _ in }
+        return sharedConfigurationDirector
     } catch {
         observabilityScope.emit(warning: "Failed creating default configuration location, \(error)")
         return .none
@@ -1071,7 +1074,10 @@ private func getSharedCacheDirectory(options: SwiftToolOptions, observabilitySco
     }
 
     do {
-        return try localFileSystem.getOrCreateSwiftPMCacheDirectory()
+        let sharedCacheDirector = try localFileSystem.getOrCreateSwiftPMCacheDirectory()
+        // make sure we can write files
+        try withTemporaryFile(dir: sharedCacheDirector) { _ in }
+        return sharedCacheDirector
     } catch {
         observabilityScope.emit(warning: "Failed creating default cache location, \(error)")
         return .none

Sources/SPMTestSupport/InMemoryGitRepository.swift

@@ -204,7 +204,6 @@ public final class InMemoryGitRepository {
 }
 
 extension InMemoryGitRepository: FileSystem {
-
     public func exists(_ path: AbsolutePath, followSymlink: Bool) -> Bool {
         self.lock.withLock {
             self.head.fileSystem.exists(path, followSymlink: followSymlink)
@@ -251,6 +250,10 @@ extension InMemoryGitRepository: FileSystem {
         fatalError("Unsupported")
     }
 
+    public var tempDirectory: AbsolutePath {
+        fatalError("Unsupported")
+    }
+
     public func getDirectoryContents(_ path: AbsolutePath) throws -> [String] {
         try self.lock.withLock {
             try self.head.fileSystem.getDirectoryContents(path)

Sources/SourceControl/GitRepository.swift

@@ -890,6 +890,10 @@ private class GitFileSystemView: FileSystem {
         fatalError("unsupported")
     }
 
+    public var tempDirectory: AbsolutePath {
+        fatalError("unsupported")
+    }
+
     func createDirectory(_ path: AbsolutePath) throws {
         throw FileSystemError(.unsupported, path)
     }

Tests/BasicsTests/URLSessionHTTPClientTests.swift

@@ -704,6 +704,10 @@ class FailingFileSystem: FileSystem {
         fatalError("unexpected call")
     }
 
+    var tempDirectory: AbsolutePath {
+        fatalError("unexpected call")
+    }
+
     func changeCurrentWorkingDirectory(to path: AbsolutePath) throws {
         fatalError("unexpected call")
     }