Skip to content

Commit 106bba9

Browse files
committed
Merge branch 'master' into add-kickstarter-oss
# Conflicts: # projects.json
2 parents f288417 + 2b4ce7c commit 106bba9

File tree

3 files changed

+312
-329
lines changed

3 files changed

+312
-329
lines changed

project_future.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@ def get_build_command(self, incremental=False):
118118
+ ['CODE_SIGN_IDENTITY=',
119119
'CODE_SIGNING_REQUIRED=NO',
120120
'ENABLE_BITCODE=NO',
121+
'-UseNewBuildSystem=NO',
121122
'INDEX_ENABLE_DATA_STORE=NO',
122123
'GCC_TREAT_WARNINGS_AS_ERRORS=NO',
123124
'SWIFT_TREAT_WARNINGS_AS_ERRORS=NO'])

project_precommit_check

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,9 @@ supported_configs = {
6868
},
6969
'4.2': {
7070
'version': 'Apple Swift version 4.2 '
71-
'(swiftlang-1000.0.16.9 clang-1000.10.25.3)\n'
71+
'(swiftlang-1000.0.25.1 clang-1000.10.28.1)\n'
7272
'Target: x86_64-apple-darwin17.7.0\n',
73-
'description': 'Xcode 10 Beta 2 (contains Swift 4.2)',
73+
'description': 'Xcode 10 Beta 3 (contains Swift 4.2)',
7474
'branch': 'swift-4.2-branch'
7575
}
7676
},
@@ -145,7 +145,7 @@ def is_correct_swift_version(swiftc, compatibility_version):
145145
error_msg = "error: please select {description}".format(
146146
description=supported_configs[platform.system()][compatibility_version]['description']
147147
)
148-
if swift_version != expected_swift_version:
148+
if swift_version.split("\n")[0] != expected_swift_version.split("\n")[0]:
149149
common.debug_print("--- Version check failed ---")
150150
common.debug_print("Expected version:\n" + expected_swift_version)
151151
common.debug_print("Current version:\n" + swift_version)

0 commit comments

Comments
 (0)