Fix builder factory to handle Swift version 4.2 correctly #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if both major and minor versions as specified minor would be stripped out and only major gets set in actual `xcodebuild` flags, but `4.2` is a valid version which has to be supported.
|
@swift-ci please test |
|
This test run looks better than the other. Closing #292 in favor of this. |
|
@clackary @shahmishal Looks like Alamofire, Evergreen, Kickstarter and LaunchScreenSnapshot all have to be marked as |
…hot as compatible with 4.0 instead of 4.2 Because of all the aforementioned projects use APIs obsoleted in 4.2
|
@swift-ci please test |
|
Looks like tests are green, going to merge in the morning if nobody objects. |
shahmishal
approved these changes
Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if both major and minor versions as specified minor would
be stripped out and only major gets set in actual
xcodebuildflags,but
4.2is a valid version which has to be supported.