Skip to content

Fix Kingfisher build by the new scheme settings #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

onevcat
Copy link
Contributor

@onevcat onevcat commented Apr 22, 2021

This is a fix for #527

It now succeeds as below:

--- Executing build actions ---
$ /Users/onevcat/Desktop/swift-source-compat-suite/runner.py --swift-branch swift-5.1-branch --swiftc /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swiftc --projects /Users/onevcat/Desktop/swift-source-compat-suite/projects.json --include-repos 'path == "Kingfisher"' --include-versions 'version == "5.1"' --include-actions 'action.startswith("Build")'
$ git -C /Users/onevcat/Desktop/swift-source-compat-suite/project_cache/Kingfisher rev-parse --show-toplevel
PASS: Kingfisher, 5.1, 44450a, Kingfisher, generic/platform=iOS
$ git -C /Users/onevcat/Desktop/swift-source-compat-suite/project_cache/Kingfisher rev-parse --show-toplevel
PASS: Kingfisher, 5.1, 44450a, Kingfisher, generic/platform=macOS
$ git -C /Users/onevcat/Desktop/swift-source-compat-suite/project_cache/Kingfisher rev-parse --show-toplevel
PASS: Kingfisher, 5.1, 44450a, Kingfisher, generic/platform=tvOS
$ git -C /Users/onevcat/Desktop/swift-source-compat-suite/project_cache/Kingfisher rev-parse --show-toplevel
PASS: Kingfisher, 5.1, 44450a, Kingfisher, generic/platform=watchOS
========================================
Action Summary:
     Passed: 4
     Failed: 0
    XFailed: 0
    UPassed: 0
      Total: 4
========================================
Repository Summary:
      Total: 1
========================================
Result: PASS
========================================
--- Kingfisher checked successfully against Swift 5.1 ---

@shahmishal
Copy link
Member

@swift-ci test

@shahmishal shahmishal merged commit 02fbd60 into swiftlang:main Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants