Skip to content

Commit 07d5098

Browse files
committed
Enable the API breakage checks
Fixes #2986
1 parent 61caf25 commit 07d5098

File tree

4 files changed

+9
-2
lines changed

4 files changed

+9
-2
lines changed

.github/workflows/pull_request.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,7 @@ jobs:
1616
uses: swiftlang/github-workflows/.github/workflows/soundness.yml@main
1717
with:
1818
license_header_check_project_name: "Swift.org"
19-
# https://github.com/swiftlang/swift-syntax/issues/2986
20-
api_breakage_check_enabled: false
19+
api_breakage_check_allowlist_path: "Release Notes/api-breakages.txt"
2120
# https://github.com/swiftlang/swift-syntax/issues/2987
2221
docs_check_enabled: false
2322
# https://github.com/swiftlang/swift-syntax/issues/2988
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
# API Breakage Checks
2+
3+
We have a CI jobs that checks for API breakages. Since swift-syntax releases increase the major version number, it is possible to make API-breaking changes – but we should avoid them whenever possible to avoid churn on clients when they update to a new swift-syntax version.
4+
5+
If your change contains an API breaking change, add the change to `api-breakages.txt`. All API breaking changes should be accompanied by an [RFC](RFC%20Process.md).

Contributor Documentation/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
The following documentation documents are primarily intended for developers of swift-syntax.
44

5+
- [API Breakage Checks](API%20Breakage%20Checks.md)
56
- [Changing Swift Syntax](Changing%20Swift%20Syntax.md)
67
- [Filing Parser Bug Reports](Filing%20Parser%20Bug%20Reports.md)
78
- [Fixing Bugs](Fixing%20Bugs.md)

api-breakages.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
6.2
2+
---

0 commit comments

Comments
 (0)