Merge pull request #871 from ahoppen/ahoppen/no-diagnostics-if-no-error

ahoppen · web-flow · commit 093e5ee151d2 · 2022-10-01T12:14:55.000+02:00
Skip subtrees that don’t contain any errors during diagnostic generation
diff --git a/Sources/SwiftParser/Diagnostics/ParseDiagnosticsGenerator.swift b/Sources/SwiftParser/Diagnostics/ParseDiagnosticsGenerator.swift
@@ -89,6 +89,9 @@ public class ParseDiagnosticsGenerator: SyntaxAnyVisitor {
   /// Whether the node should be skipped for diagnostic emission.
   /// Every visit method must check this at the beginning.
   func shouldSkip<T: SyntaxProtocol>(_ node: T) -> Bool {
+    if !node.hasError {
+      return true
+    }
     return handledNodes.contains(node.id)
   }
 

Original file line number	Diff line number	Diff line change
`@@ -89,6 +89,9 @@ public class ParseDiagnosticsGenerator: SyntaxAnyVisitor {`
`89`	`89`	`/// Whether the node should be skipped for diagnostic emission.`
`90`	`90`	`/// Every visit method must check this at the beginning.`
`91`	`91`	`func shouldSkip<T: SyntaxProtocol>(_ node: T) -> Bool {`
	`92`	`+ if !node.hasError {`
	`93`	`+ return true`
	`94`	`+ }`
`92`	`95`	`return handledNodes.contains(node.id)`
`93`	`96`	`}`
`94`	`97`