Improvements in FunctionCallExpr convenience initializer

* Default values for left/right paren arguments
* `calledExpression` accepts `ExpressibleAsExprBuildable`,
  so `MemberAccessExpr` could be passed as well as `IdentifierExpr`
* Tests and usages are updated/simplified

Author: evnik

Sources/SwiftSyntaxBuilder/FunctionCallExprConvenienceInitializers.swift

@@ -15,15 +15,15 @@ import SwiftSyntax
 
 extension FunctionCallExpr {
   public init(
-    _ calledExpression: ExpressibleAsIdentifierExpr,
-    leftParen: TokenSyntax? = nil,
-    rightParen: TokenSyntax? = nil,
+    _ calledExpression: ExpressibleAsExprBuildable,
+    leftParen: TokenSyntax? = .leftParen,
+    rightParen: TokenSyntax? = .rightParen,
     trailingClosure: ExpressibleAsClosureExpr? = nil,
     @TupleExprElementListBuilder argumentListBuilder: () -> ExpressibleAsTupleExprElementList = { TupleExprElementList([]) },
     @MultipleTrailingClosureElementListBuilder additionalTrailingClosuresBuilder: () -> MultipleTrailingClosureElementList? = { nil }
   ) {
     self.init(
-      calledExpression: calledExpression.createIdentifierExpr(),
+      calledExpression: calledExpression.createExprBuildable(),
       leftParen: leftParen,
       argumentList: argumentListBuilder(),
       rightParen: rightParen,

Sources/SwiftSyntaxBuilderGeneration/main.swift

@@ -17,15 +17,15 @@ import SwiftSyntaxBuilder
 private let format = Format(indentWidth: 2)
 
 private func createSpacingCall() -> FunctionCallExpr {
-  FunctionCallExpr(calledExpression: MemberAccessExpr(name: "spaces"), leftParen: .leftParen, argumentList: TupleExprElement(expression: IntegerLiteralExpr(1)), rightParen: .rightParen)
+  FunctionCallExpr(MemberAccessExpr(name: "spaces"), argumentListBuilder: { TupleExprElement(expression: IntegerLiteralExpr(1)) })
 }
 
 private func createWithLeadingTriviaCall() -> FunctionCallExpr {
-  FunctionCallExpr(calledExpression: MemberAccessExpr(name: "withLeadingTrivia"), leftParen: .leftParen, argumentList: TupleExprElement.init(expression: createSpacingCall()), rightParen: .rightParen)
+  FunctionCallExpr(MemberAccessExpr(name: "withLeadingTrivia"), argumentListBuilder: { TupleExprElement(expression: createSpacingCall()) })
 }
 
 private func createWithTrailingTriviaCall() -> FunctionCallExpr {
-  FunctionCallExpr(calledExpression: MemberAccessExpr(name: "withTrailingTrivia"), leftParen: .leftParen, argumentList: TupleExprElement(expression: createSpacingCall()), rightParen: .rightParen)
+  FunctionCallExpr(MemberAccessExpr(name: "withTrailingTrivia"), argumentListBuilder: { TupleExprElement(expression: createSpacingCall()) })
 }
 
 private func createTokenSyntaxPatternBinding(_ pattern: ExpressibleAsPatternBuildable, accessor: ExpressibleAsSyntaxBuildable) -> PatternBinding {
@@ -72,9 +72,7 @@ let tokensFile = SourceFile {
             // We need to use `CodeBlock` here to ensure there is braces around.
 
             let accessor = CodeBlock {
-              FunctionCallExpr(calledExpression: MemberAccessExpr(base: "SyntaxFactory", name: "make\(token.name)Keyword"),
-                               leftParen: .leftParen,
-                               rightParen: .rightParen)
+              FunctionCallExpr(MemberAccessExpr(base: "SyntaxFactory", name: "make\(token.name)Keyword"))
 
               if token.requiresLeadingSpace {
                 createWithLeadingTriviaCall()
@@ -99,9 +97,7 @@ let tokensFile = SourceFile {
                        bindingsBuilder: {
             // We need to use `CodeBlock` here to ensure there is braces around.
             let accessor = CodeBlock {
-              FunctionCallExpr(calledExpression: MemberAccessExpr(base: "SyntaxFactory", name: "make\(token.name)Token"),
-                               leftParen: .leftParen,
-                               rightParen: .rightParen)
+              FunctionCallExpr(MemberAccessExpr(base: "SyntaxFactory", name: "make\(token.name)Token"))
 
               if token.requiresLeadingSpace {
                 createWithLeadingTriviaCall()
@@ -115,7 +111,7 @@ let tokensFile = SourceFile {
             createTokenSyntaxPatternBinding("`\(token.name.withFirstCharacterLowercased)`", accessor: accessor)
           })
         } else {
-          let signature = FunctionSignature(input: ParameterClause(leftParen: TokenSyntax.leftParen, parameterList: FunctionParameter(attributes: nil, firstName: .wildcard, secondName: .identifier("text"), colon: .colon, type: "String"), rightParen: .rightParen.withTrailingTrivia(.spaces(1))), output: "TokenSyntax")
+          let signature = FunctionSignature(input: ParameterClause(parameterList: FunctionParameter(attributes: nil, firstName: .wildcard, secondName: .identifier("text"), colon: .colon, type: "String"), rightParen: .rightParen.withTrailingTrivia(.spaces(1))), output: "TokenSyntax")
 
           FunctionDecl(identifier: .identifier("`\(token.name.withFirstCharacterLowercased)`"),
                        signature: signature,
@@ -127,7 +123,7 @@ let tokensFile = SourceFile {
             }
           },
                        bodyBuilder: {
-            FunctionCallExpr(calledExpression: MemberAccessExpr(base: "SyntaxFactory", name: "make\(token.name)"), leftParen: .leftParen, rightParen: .rightParen, trailingClosure: nil, argumentListBuilder: {
+            FunctionCallExpr(MemberAccessExpr(base: "SyntaxFactory", name: "make\(token.name)"), argumentListBuilder: {
               TupleExprElement(expression: IdentifierExpr("text"))
             })
 
@@ -146,12 +142,10 @@ let tokensFile = SourceFile {
                    bindingsBuilder: {
         // We need to use `CodeBlock` here to ensure there is braces around.
         let body = CodeBlock {
-          FunctionCallExpr(calledExpression: MemberAccessExpr(base: "SyntaxFactory", name: "makeToken"),
-                           leftParen: .leftParen,
-                           rightParen: .rightParen,
+          FunctionCallExpr(MemberAccessExpr(base: "SyntaxFactory", name: "makeToken"),
                            argumentListBuilder: {
-            TupleExprElement(expression: FunctionCallExpr(calledExpression: MemberAccessExpr(name: "eof")), trailingComma: .comma)
-            TupleExprElement(label: TokenSyntax.identifier("presence"), colon: .colon, expression: FunctionCallExpr(calledExpression: MemberAccessExpr(name: "present")))
+            TupleExprElement(expression: MemberAccessExpr(name: "eof"), trailingComma: .comma)
+            TupleExprElement(label: TokenSyntax.identifier("presence"), colon: .colon, expression: MemberAccessExpr(name: "present"))
           })
         }
 
@@ -162,9 +156,7 @@ let tokensFile = SourceFile {
                    bindingsBuilder: {
         // We need to use `CodeBlock` here to ensure there is braces around.
         let body = CodeBlock {
-          FunctionCallExpr(calledExpression: MemberAccessExpr(base: "SyntaxFactory", name: "makeContextualKeyword"),
-                           leftParen: .leftParen,
-                           rightParen: .rightParen,
+          FunctionCallExpr(MemberAccessExpr(base: "SyntaxFactory", name: "makeContextualKeyword"),
                            argumentListBuilder: {
             TupleExprElement(expression: StringLiteralExpr("open"))
           })

Tests/SwiftSyntaxBuilderTest/ExtensionDeclTests.swift

@@ -7,9 +7,7 @@ final class ExtensionDeclTests: XCTestCase {
     let keywords = ["associatedtype", "class"].map { keyword -> VariableDecl in
       // We need to use `CodeBlock` here to ensure there is braces around.
       let body = CodeBlock {
-        FunctionCallExpr("SyntaxFactory.make\(keyword)Keyword",
-                         leftParen: .leftParen,
-                         rightParen: .rightParen)
+        FunctionCallExpr("SyntaxFactory.make\(keyword)Keyword")
       }
 
       return VariableDecl(letOrVarKeyword: .var,

Tests/SwiftSyntaxBuilderTest/FunctionTests.swift

@@ -24,7 +24,7 @@ final class FunctionTests: XCTestCase {
       ]), body: ifCodeBlock)
 
       ReturnStmt(expression: SequenceExpr(elementsBuilder: {
-        FunctionCallExpr(calledExpression: IdentifierExpr("fibonacci"), leftParen: .leftParen, rightParen: .rightParen, argumentListBuilder: {
+        FunctionCallExpr("fibonacci", argumentListBuilder: {
           TupleExprElement(expression: SequenceExpr(elementsBuilder: {
             IntegerLiteralExpr(digits: "n")
 
@@ -36,7 +36,7 @@ final class FunctionTests: XCTestCase {
 
         BinaryOperatorExpr("+")
 
-        FunctionCallExpr("fibonacci", leftParen: .leftParen, rightParen: .rightParen, argumentListBuilder: {
+        FunctionCallExpr(MemberAccessExpr(base: "self", name: "fibonacci"), argumentListBuilder: {
           TupleExprElement(expression: SequenceExpr(elementsBuilder: {
             IntegerLiteralExpr(digits: "n")
 
@@ -56,7 +56,7 @@ final class FunctionTests: XCTestCase {
           if n <= 1{
               return n
           }
-          return fibonacci(n - 1) + fibonacci(n - 2)
+          return fibonacci(n - 1) + self.fibonacci(n - 2)
       }
       """)
   }