Remove the old (non-result-builder) SyntaxBuilder

We’ve got by far to many ways to generate SwiftSyntax nodes. Remove the old SyntaxBuilder because, AFAICT, it’s not really used much.

This PR migrates tests from the older builder to SyntaxFactory. I’ll likely remove SyntaxFactory in a follow-up PR in favor of initializers or static methods on the syntax types you want to create.

rdar://98318651

Author: ahoppen

Package.swift

@@ -54,21 +54,20 @@ let package = Package(
       name: "SwiftSyntax",
       dependencies: ["_CSwiftSyntax"],
       exclude: [
-        "SyntaxFactory.swift.gyb",
-        "SyntaxTraits.swift.gyb",
-        "Trivia.swift.gyb",
         "Misc.swift.gyb",
-        "SyntaxRewriter.swift.gyb",
-        "SyntaxEnum.swift.gyb",
+        "SyntaxAnyVisitor.swift.gyb",
+        "SyntaxBaseNodes.swift.gyb",
         "SyntaxClassification.swift.gyb",
-        "SyntaxBuilders.swift.gyb",
-        "TokenKind.swift.gyb",
-        "SyntaxVisitor.swift.gyb",
         "SyntaxCollections.swift.gyb",
-        "SyntaxBaseNodes.swift.gyb",
-        "SyntaxAnyVisitor.swift.gyb",
-        "SyntaxNodes.swift.gyb.template",
+        "SyntaxEnum.swift.gyb",
+        "SyntaxFactory.swift.gyb",
         "SyntaxKind.swift.gyb",
+        "SyntaxNodes.swift.gyb.template",
+        "SyntaxRewriter.swift.gyb",
+        "SyntaxTraits.swift.gyb",
+        "SyntaxVisitor.swift.gyb",
+        "TokenKind.swift.gyb",
+        "Trivia.swift.gyb",
       ],
       swiftSettings: swiftSyntaxSwiftSettings
     ),