Skip to content

Commit 153b464

Browse files
committed
Rename buildProduct to snake_case
As per the Python convention
1 parent 081d9c4 commit 153b464

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

build-script.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -459,7 +459,7 @@ def __get_swiftpm_invocation(self, package_dir: str) -> List[str]:
459459
invocation.append("--verbose")
460460
return invocation
461461

462-
def buildProduct(self, product_name: str) -> None:
462+
def build_product(self, product_name: str) -> None:
463463
print("** Building product " + product_name + " **")
464464
self.__build(PACKAGE_DIR, product_name)
465465

@@ -754,13 +754,13 @@ def build_command(args: argparse.Namespace) -> None:
754754
)
755755
# Until rdar://53881101 is implemented, we cannot request a build of multiple
756756
# targets simultaneously. For now, just build one product after the other.
757-
builder.buildProduct("SwiftSyntax")
758-
builder.buildProduct("SwiftSyntaxParser")
759-
builder.buildProduct("SwiftSyntaxBuilder")
757+
builder.build_product("SwiftSyntax")
758+
builder.build_product("SwiftSyntaxParser")
759+
builder.build_product("SwiftSyntaxBuilder")
760760

761761
# Build examples
762-
builder.buildProduct("AddOneToIntegerLiterals")
763-
builder.buildProduct("CodeGenerationUsingSwiftSyntaxBuilder")
762+
builder.build_product("AddOneToIntegerLiterals")
763+
builder.build_product("CodeGenerationUsingSwiftSyntaxBuilder")
764764
except subprocess.CalledProcessError as e:
765765
fail_for_called_process_error("Building SwiftSyntax failed", e)
766766

@@ -776,7 +776,7 @@ def test_command(args: argparse.Namespace) -> None:
776776
disable_sandbox=args.disable_sandbox,
777777
)
778778

779-
builder.buildProduct("lit-test-helper")
779+
builder.build_product("lit-test-helper")
780780

781781
run_tests(
782782
toolchain=args.toolchain,

0 commit comments

Comments
 (0)