Skip to content

Commit 184930a

Browse files
authored
Merge pull request #2405 from apple/rename-nonescapable
Rename NonesapableTypes feature
2 parents 982dea8 + d9832e8 commit 184930a

File tree

8 files changed

+15
-15
lines changed

8 files changed

+15
-15
lines changed

CodeGeneration/Sources/SyntaxSupport/ExperimentalFeatures.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public enum ExperimentalFeature: String, CaseIterable {
1717
case thenStatements
1818
case typedThrows
1919
case doExpressions
20-
case nonEscapableTypes
20+
case nonescapableTypes
2121

2222
/// The name of the feature, which is used in the doc comment.
2323
public var featureName: String {
@@ -30,7 +30,7 @@ public enum ExperimentalFeature: String, CaseIterable {
3030
return "typed throws"
3131
case .doExpressions:
3232
return "'do' expressions"
33-
case .nonEscapableTypes:
33+
case .nonescapableTypes:
3434
return "NonEscableTypes"
3535
}
3636
}

CodeGeneration/Sources/SyntaxSupport/KeywordSpec.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -619,9 +619,9 @@ public enum Keyword: CaseIterable {
619619
case .required:
620620
return KeywordSpec("required")
621621
case ._resultDependsOn:
622-
return KeywordSpec("_resultDependsOn", experimentalFeature: .nonEscapableTypes)
622+
return KeywordSpec("_resultDependsOn", experimentalFeature: .nonescapableTypes)
623623
case ._resultDependsOnSelf:
624-
return KeywordSpec("_resultDependsOnSelf", experimentalFeature: .nonEscapableTypes)
624+
return KeywordSpec("_resultDependsOnSelf", experimentalFeature: .nonescapableTypes)
625625
case .rethrows:
626626
return KeywordSpec("rethrows", isLexerClassified: true)
627627
case .retroactive:

Sources/SwiftParser/Modifiers.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ extension Parser {
8686
(.declarationModifier(._local), let handle)?,
8787
(.declarationModifier(.__setter_access), let handle)?,
8888
(.declarationModifier(.reasync), let handle)?,
89-
(.declarationModifier(._resultDependsOnSelf), let handle)? where experimentalFeatures.contains(.nonEscapableTypes):
89+
(.declarationModifier(._resultDependsOnSelf), let handle)? where experimentalFeatures.contains(.nonescapableTypes):
9090
let (unexpectedBeforeKeyword, keyword) = self.eat(handle)
9191
elements.append(RawDeclModifierSyntax(unexpectedBeforeKeyword, name: keyword, detail: nil, arena: self.arena))
9292
case (.declarationModifier(.rethrows), _)?:

Sources/SwiftParser/Patterns.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,7 @@ extension Parser.Lookahead {
353353
&& !self.at(.keyword(.__owned))
354354
&& !self.at(.keyword(.borrowing))
355355
&& !self.at(.keyword(.consuming))
356-
&& !(experimentalFeatures.contains(.nonEscapableTypes) && self.at(.keyword(._resultDependsOn)))
356+
&& !(experimentalFeatures.contains(.nonescapableTypes) && self.at(.keyword(._resultDependsOn)))
357357
{
358358
return true
359359
}

Sources/SwiftParser/TokenSpecSet.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -416,8 +416,8 @@ enum DeclarationModifier: TokenSpecSet {
416416
case TokenSpec(.static): self = .static
417417
case TokenSpec(.unowned): self = .unowned
418418
case TokenSpec(.weak): self = .weak
419-
case TokenSpec(._resultDependsOn) where experimentalFeatures.contains(.nonEscapableTypes): self = ._resultDependsOn
420-
case TokenSpec(._resultDependsOnSelf) where experimentalFeatures.contains(.nonEscapableTypes): self = ._resultDependsOnSelf
419+
case TokenSpec(._resultDependsOn) where experimentalFeatures.contains(.nonescapableTypes): self = ._resultDependsOn
420+
case TokenSpec(._resultDependsOnSelf) where experimentalFeatures.contains(.nonescapableTypes): self = ._resultDependsOnSelf
421421
default: return nil
422422
}
423423
}

Sources/SwiftParser/generated/ExperimentalFeatures.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,5 +37,5 @@ extension Parser.ExperimentalFeatures {
3737
public static let doExpressions = Self (rawValue: 1 << 3)
3838

3939
/// Whether to enable the parsing of NonEscableTypes.
40-
public static let nonEscapableTypes = Self (rawValue: 1 << 4)
40+
public static let nonescapableTypes = Self (rawValue: 1 << 4)
4141
}

Sources/SwiftParser/generated/Parser+TokenSpecSet.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ extension AttributedTypeSyntax {
202202
self = .borrowing
203203
case TokenSpec(.consuming):
204204
self = .consuming
205-
case TokenSpec(._resultDependsOn) where experimentalFeatures.contains(.nonEscapableTypes):
205+
case TokenSpec(._resultDependsOn) where experimentalFeatures.contains(.nonescapableTypes):
206206
self = ._resultDependsOn
207207
default:
208208
return nil
@@ -793,7 +793,7 @@ extension DeclModifierSyntax {
793793
self = .public
794794
case TokenSpec(.reasync):
795795
self = .reasync
796-
case TokenSpec(._resultDependsOnSelf) where experimentalFeatures.contains(.nonEscapableTypes):
796+
case TokenSpec(._resultDependsOnSelf) where experimentalFeatures.contains(.nonescapableTypes):
797797
self = ._resultDependsOnSelf
798798
case TokenSpec(.required):
799799
self = .required

Tests/SwiftParserTest/DeclarationTests.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3105,7 +3105,7 @@ final class DeclarationTests: ParserTestCase {
31053105
}
31063106
}
31073107
""",
3108-
experimentalFeatures: .nonEscapableTypes
3108+
experimentalFeatures: .nonescapableTypes
31093109
)
31103110

31113111
assertParse(
@@ -3116,7 +3116,7 @@ final class DeclarationTests: ParserTestCase {
31163116
}
31173117
}
31183118
""",
3119-
experimentalFeatures: .nonEscapableTypes
3119+
experimentalFeatures: .nonescapableTypes
31203120
)
31213121
}
31223122

@@ -3128,7 +3128,7 @@ final class DeclarationTests: ParserTestCase {
31283128
return Builtin.unsafeCastToNativeObject(x)
31293129
}
31303130
""",
3131-
experimentalFeatures: .nonEscapableTypes
3131+
experimentalFeatures: .nonescapableTypes
31323132
)
31333133

31343134
assertParse(
@@ -3138,7 +3138,7 @@ final class DeclarationTests: ParserTestCase {
31383138
return (Builtin.unsafeCastToNativeObject(x), Builtin.unsafeCastToNativeObject(x))
31393139
}
31403140
""",
3141-
experimentalFeatures: .nonEscapableTypes
3141+
experimentalFeatures: .nonescapableTypes
31423142
)
31433143
}
31443144
}

0 commit comments

Comments
 (0)