Skip to content

Commit 4f9fbaf

Browse files
committed
Remove leading and trailing space from < and >
1 parent f3b87b8 commit 4f9fbaf

File tree

5 files changed

+10
-42
lines changed

5 files changed

+10
-42
lines changed

CodeGeneration/Sources/SyntaxSupport/gyb_generated/TokenSpec.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -261,8 +261,8 @@ public let SYNTAX_TOKENS: [TokenSpec] = [
261261
PunctuatorSpec(name: "RightBrace", kind: "r_brace", text: "}"),
262262
PunctuatorSpec(name: "LeftSquareBracket", kind: "l_square", text: "["),
263263
PunctuatorSpec(name: "RightSquareBracket", kind: "r_square", text: "]"),
264-
PunctuatorSpec(name: "LeftAngle", kind: "l_angle", text: "<", requiresLeadingSpace: true, requiresTrailingSpace: true),
265-
PunctuatorSpec(name: "RightAngle", kind: "r_angle", text: ">", requiresLeadingSpace: true, requiresTrailingSpace: true),
264+
PunctuatorSpec(name: "LeftAngle", kind: "l_angle", text: "<"),
265+
PunctuatorSpec(name: "RightAngle", kind: "r_angle", text: ">"),
266266
PunctuatorSpec(name: "Period", kind: "period", text: "."),
267267
PunctuatorSpec(name: "Comma", kind: "comma", text: ",", requiresTrailingSpace: true),
268268
PunctuatorSpec(name: "Ellipsis", kind: "ellipsis", text: "..."),

CodeGeneration/Sources/generate-swiftsyntax/templates/basicformat/BasicFormatFile.swift

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -124,12 +124,7 @@ let basicFormatFile = SourceFile {
124124
FunctionDecl("open func requiresLeadingSpace(_ token: TokenSyntax) -> Bool") {
125125
SwitchStmt("""
126126
switch (token.previousToken(viewMode: .sourceAccurate)?.tokenKind, token.tokenKind) {
127-
case (.identifier, .leftAngle),
128-
(.identifier, .rightAngle),
129-
(.rightAngle, .exclamationMark),
130-
(.rightAngle, .rightBrace),
131-
(.rightSquareBracket, .rightAngle),
132-
(.postfixQuestionMark, .rightAngle):
127+
case (.postfixQuestionMark, .rightAngle):
133128
return false
134129
case (.leftParen, .spacedBinaryOperator("*")):
135130
return false
@@ -161,12 +156,6 @@ let basicFormatFile = SourceFile {
161156
(.exclamationMark, .period),
162157
(.initKeyword, .leftParen),
163158
(.initKeyword, .postfixQuestionMark),
164-
(.rightAngle, .exclamationMark),
165-
(.leftAngle, .identifier),
166-
(.leftAngle, .leftSquareBracket),
167-
(.leftAngle, .leftBrace),
168-
(.rightAngle, .leftParen),
169-
(.rightAngle, .postfixQuestionMark),
170159
(.postfixQuestionMark, .leftParen),
171160
(.postfixQuestionMark, .rightAngle),
172161
(.postfixQuestionMark, .rightParen),

Sources/SwiftBasicFormat/generated/BasicFormat.swift

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -125,12 +125,7 @@ open class BasicFormat: SyntaxRewriter {
125125

126126
open func requiresLeadingSpace(_ token: TokenSyntax) -> Bool {
127127
switch (token.previousToken(viewMode: .sourceAccurate)?.tokenKind, token.tokenKind) {
128-
case (.identifier, .leftAngle),
129-
(.identifier, .rightAngle),
130-
(.rightAngle, .exclamationMark),
131-
(.rightAngle, .rightBrace),
132-
(.rightSquareBracket, .rightAngle),
133-
(.postfixQuestionMark, .rightAngle):
128+
case (.postfixQuestionMark, .rightAngle):
134129
return false
135130
case (.leftParen, .spacedBinaryOperator("*")):
136131
return false
@@ -146,10 +141,6 @@ open class BasicFormat: SyntaxRewriter {
146141
return true
147142
case .leftBrace:
148143
return true
149-
case .leftAngle:
150-
return true
151-
case .rightAngle:
152-
return true
153144
case .equal:
154145
return true
155146
case .arrow:
@@ -169,12 +160,6 @@ open class BasicFormat: SyntaxRewriter {
169160
(.exclamationMark, .period),
170161
(.initKeyword, .leftParen),
171162
(.initKeyword, .postfixQuestionMark),
172-
(.rightAngle, .exclamationMark),
173-
(.leftAngle, .identifier),
174-
(.leftAngle, .leftSquareBracket),
175-
(.leftAngle, .leftBrace),
176-
(.rightAngle, .leftParen),
177-
(.rightAngle, .postfixQuestionMark),
178163
(.postfixQuestionMark, .leftParen),
179164
(.postfixQuestionMark, .rightAngle),
180165
(.postfixQuestionMark, .rightParen),
@@ -277,10 +262,6 @@ open class BasicFormat: SyntaxRewriter {
277262
return true
278263
case .wildcardKeyword:
279264
return true
280-
case .leftAngle:
281-
return true
282-
case .rightAngle:
283-
return true
284265
case .comma:
285266
return true
286267
case .colon:

Sources/SwiftSyntax/gyb_generated/SyntaxFactory.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9307,17 +9307,17 @@ public enum SyntaxFactory {
93079307
}
93089308
@available(*, deprecated, message: "Use TokenSyntax.leftAngleToken instead")
93099309
public static func makeLeftAngleToken(
9310-
leadingTrivia: Trivia = .space,
9311-
trailingTrivia: Trivia = .space
9310+
leadingTrivia: Trivia = [],
9311+
trailingTrivia: Trivia = []
93129312
) -> TokenSyntax {
93139313
return makeToken(.leftAngle, presence: .present,
93149314
leadingTrivia: leadingTrivia,
93159315
trailingTrivia: trailingTrivia)
93169316
}
93179317
@available(*, deprecated, message: "Use TokenSyntax.rightAngleToken instead")
93189318
public static func makeRightAngleToken(
9319-
leadingTrivia: Trivia = .space,
9320-
trailingTrivia: Trivia = .space
9319+
leadingTrivia: Trivia = [],
9320+
trailingTrivia: Trivia = []
93219321
) -> TokenSyntax {
93229322
return makeToken(.rightAngle, presence: .present,
93239323
leadingTrivia: leadingTrivia,

gyb_syntax_support/Token.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -254,10 +254,8 @@ def macro_name(self):
254254
Punctuator('RightBrace', 'r_brace', text='}'),
255255
Punctuator('LeftSquareBracket', 'l_square', text='['),
256256
Punctuator('RightSquareBracket', 'r_square', text=']'),
257-
Punctuator('LeftAngle', 'l_angle', text='<', requires_leading_space=True,
258-
requires_trailing_space=True),
259-
Punctuator('RightAngle', 'r_angle', text='>', requires_leading_space=True,
260-
requires_trailing_space=True),
257+
Punctuator('LeftAngle', 'l_angle', text='<'),
258+
Punctuator('RightAngle', 'r_angle', text='>'),
261259

262260
Punctuator('Period', 'period', text='.'),
263261
Punctuator('Comma', 'comma', text=',', requires_trailing_space=True),

0 commit comments

Comments
 (0)