Merge pull request #728 from CodaFi/a-pattern-of-behavior

#keyPath Expressions Don't Actually Allow Compound Names

Author: CodaFi

Sources/SwiftParser/Expressions.swift

@@ -1284,12 +1284,13 @@ extension Parser {
     // Parse the sequence of unqualified-names.
     var elements = [RawObjcNamePieceSyntax]()
     do {
-      var flags: DeclNameOptions = .compoundNames
+      var flags: DeclNameOptions = []
       var keepGoing: RawTokenSyntax? = nil
       var loopProgress = LoopProgressCondition()
       repeat {
         // Parse the next name.
-        let (name, _) = self.parseDeclNameRef(flags)
+        let (name, args) = self.parseDeclNameRef(flags)
+        assert(args == nil, "Found arguments but did not pass argument flag?")
 
         // After the first component, we can start parsing keywords.
         flags.formUnion(.keywords)

Tests/SwiftParserTest/Expressions.swift

@@ -412,6 +412,12 @@ final class ExpressionTests: XCTestCase {
         DiagnosticSpec(message: "Expected '}' to end function"),
       ]
     )
+
+    AssertParse("#keyPath(#^DIAG^#(b:)",
+                diagnostics: [
+                  DiagnosticSpec(message: "Expected '' in '#keyPath' expression"),
+                  DiagnosticSpec(message: "Expected ')' to end '#keyPath' expression"),
+                ])
   }
 
   func testMissingArrowInArrowExpr() {