Skip to content

Commit 695df41

Browse files
committed
Remove TupleTypeElementSyntax.initializer
The child was never used and didn’t make any sense anyway. A type can’t have a default value.
1 parent be8dc65 commit 695df41

File tree

8 files changed

+23
-82
lines changed

8 files changed

+23
-82
lines changed

CodeGeneration/Sources/SyntaxSupport/TypeNodes.swift

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -500,11 +500,6 @@ public let TYPE_NODES: [Node] = [
500500
kind: .token(choices: [.token(tokenKind: "EllipsisToken")]),
501501
isOptional: true
502502
),
503-
Child(
504-
name: "Initializer",
505-
kind: .node(kind: .initializerClause),
506-
isOptional: true
507-
),
508503
Child(
509504
name: "TrailingComma",
510505
kind: .token(choices: [.token(tokenKind: "CommaToken")]),

Sources/SwiftParser/Types.swift

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@ extension Parser {
7575
colon: nil,
7676
type: base,
7777
ellipsis: nil,
78-
initializer: nil,
7978
trailingComma: nil,
8079
arena: self.arena
8180
)
@@ -491,7 +490,6 @@ extension Parser {
491490
colon: nil,
492491
type: RawTypeSyntax(RawIdentifierTypeSyntax(name: first, genericArgumentClause: nil, arena: self.arena)),
493492
ellipsis: nil,
494-
initializer: nil,
495493
trailingComma: self.missingToken(.comma),
496494
arena: self.arena
497495
)
@@ -519,7 +517,6 @@ extension Parser {
519517
colon: colon,
520518
type: type,
521519
ellipsis: ellipsis,
522-
initializer: nil,
523520
trailingComma: trailingComma,
524521
arena: self.arena
525522
)

Sources/SwiftSyntax/generated/ChildNameForKeyPath.swift

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3229,12 +3229,8 @@ public func childName(_ keyPath: AnyKeyPath) -> String? {
32293229
return "unexpectedBetweenTypeAndEllipsis"
32303230
case \TupleTypeElementSyntax.ellipsis:
32313231
return "ellipsis"
3232-
case \TupleTypeElementSyntax.unexpectedBetweenEllipsisAndInitializer:
3233-
return "unexpectedBetweenEllipsisAndInitializer"
3234-
case \TupleTypeElementSyntax.initializer:
3235-
return "initializer"
3236-
case \TupleTypeElementSyntax.unexpectedBetweenInitializerAndTrailingComma:
3237-
return "unexpectedBetweenInitializerAndTrailingComma"
3232+
case \TupleTypeElementSyntax.unexpectedBetweenEllipsisAndTrailingComma:
3233+
return "unexpectedBetweenEllipsisAndTrailingComma"
32383234
case \TupleTypeElementSyntax.trailingComma:
32393235
return "trailingComma"
32403236
case \TupleTypeElementSyntax.unexpectedAfterTrailingComma:

Sources/SwiftSyntax/generated/RenamedChildrenCompatibility.swift

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8109,9 +8109,7 @@ extension TupleTypeElementSyntax {
81098109
type: some TypeSyntaxProtocol,
81108110
_ unexpectedBetweenTypeAndEllipsis: UnexpectedNodesSyntax? = nil,
81118111
ellipsis: TokenSyntax? = nil,
8112-
_ unexpectedBetweenEllipsisAndInitializer: UnexpectedNodesSyntax? = nil,
8113-
initializer: InitializerClauseSyntax? = nil,
8114-
_ unexpectedBetweenInitializerAndTrailingComma: UnexpectedNodesSyntax? = nil,
8112+
_ unexpectedBetweenEllipsisAndTrailingComma: UnexpectedNodesSyntax? = nil,
81158113
trailingComma: TokenSyntax? = nil,
81168114
_ unexpectedAfterTrailingComma: UnexpectedNodesSyntax? = nil,
81178115
trailingTrivia: Trivia? = nil
@@ -8131,9 +8129,7 @@ extension TupleTypeElementSyntax {
81318129
type: type,
81328130
unexpectedBetweenTypeAndEllipsis,
81338131
ellipsis: ellipsis,
8134-
unexpectedBetweenEllipsisAndInitializer,
8135-
initializer: initializer,
8136-
unexpectedBetweenInitializerAndTrailingComma,
8132+
unexpectedBetweenEllipsisAndTrailingComma,
81378133
trailingComma: trailingComma,
81388134
unexpectedAfterTrailingComma,
81398135
trailingTrivia: trailingTrivia

Sources/SwiftSyntax/generated/SyntaxCollections.swift

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2246,8 +2246,7 @@ public struct TupleTypeElementListSyntax: SyntaxCollection, SyntaxHashable {
22462246
/// - ``TupleTypeElementSyntax``.``TupleTypeElementSyntax/unexpectedBetweenSecondNameAndColon``
22472247
/// - ``TupleTypeElementSyntax``.``TupleTypeElementSyntax/unexpectedBetweenColonAndType``
22482248
/// - ``TupleTypeElementSyntax``.``TupleTypeElementSyntax/unexpectedBetweenTypeAndEllipsis``
2249-
/// - ``TupleTypeElementSyntax``.``TupleTypeElementSyntax/unexpectedBetweenEllipsisAndInitializer``
2250-
/// - ``TupleTypeElementSyntax``.``TupleTypeElementSyntax/unexpectedBetweenInitializerAndTrailingComma``
2249+
/// - ``TupleTypeElementSyntax``.``TupleTypeElementSyntax/unexpectedBetweenEllipsisAndTrailingComma``
22512250
/// - ``TupleTypeElementSyntax``.``TupleTypeElementSyntax/unexpectedAfterTrailingComma``
22522251
/// - ``TupleTypeSyntax``.``TupleTypeSyntax/unexpectedBeforeLeftParen``
22532252
/// - ``TupleTypeSyntax``.``TupleTypeSyntax/unexpectedBetweenLeftParenAndElements``

Sources/SwiftSyntax/generated/raw/RawSyntaxNodes.swift

Lines changed: 8 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -21199,15 +21199,13 @@ public struct RawTupleTypeElementSyntax: RawSyntaxNodeProtocol {
2119921199
type: RawTypeSyntax,
2120021200
_ unexpectedBetweenTypeAndEllipsis: RawUnexpectedNodesSyntax? = nil,
2120121201
ellipsis: RawTokenSyntax?,
21202-
_ unexpectedBetweenEllipsisAndInitializer: RawUnexpectedNodesSyntax? = nil,
21203-
initializer: RawInitializerClauseSyntax?,
21204-
_ unexpectedBetweenInitializerAndTrailingComma: RawUnexpectedNodesSyntax? = nil,
21202+
_ unexpectedBetweenEllipsisAndTrailingComma: RawUnexpectedNodesSyntax? = nil,
2120521203
trailingComma: RawTokenSyntax?,
2120621204
_ unexpectedAfterTrailingComma: RawUnexpectedNodesSyntax? = nil,
2120721205
arena: __shared SyntaxArena
2120821206
) {
2120921207
let raw = RawSyntax.makeLayout(
21210-
kind: .tupleTypeElement, uninitializedCount: 17, arena: arena) { layout in
21208+
kind: .tupleTypeElement, uninitializedCount: 15, arena: arena) { layout in
2121121209
layout.initialize(repeating: nil)
2121221210
layout[0] = unexpectedBeforeInoutKeyword?.raw
2121321211
layout[1] = inoutKeyword?.raw
@@ -21221,11 +21219,9 @@ public struct RawTupleTypeElementSyntax: RawSyntaxNodeProtocol {
2122121219
layout[9] = type.raw
2122221220
layout[10] = unexpectedBetweenTypeAndEllipsis?.raw
2122321221
layout[11] = ellipsis?.raw
21224-
layout[12] = unexpectedBetweenEllipsisAndInitializer?.raw
21225-
layout[13] = initializer?.raw
21226-
layout[14] = unexpectedBetweenInitializerAndTrailingComma?.raw
21227-
layout[15] = trailingComma?.raw
21228-
layout[16] = unexpectedAfterTrailingComma?.raw
21222+
layout[12] = unexpectedBetweenEllipsisAndTrailingComma?.raw
21223+
layout[13] = trailingComma?.raw
21224+
layout[14] = unexpectedAfterTrailingComma?.raw
2122921225
}
2123021226
self.init(unchecked: raw)
2123121227
}
@@ -21278,24 +21274,16 @@ public struct RawTupleTypeElementSyntax: RawSyntaxNodeProtocol {
2127821274
layoutView.children[11].map(RawTokenSyntax.init(raw:))
2127921275
}
2128021276

21281-
public var unexpectedBetweenEllipsisAndInitializer: RawUnexpectedNodesSyntax? {
21277+
public var unexpectedBetweenEllipsisAndTrailingComma: RawUnexpectedNodesSyntax? {
2128221278
layoutView.children[12].map(RawUnexpectedNodesSyntax.init(raw:))
2128321279
}
2128421280

21285-
public var initializer: RawInitializerClauseSyntax? {
21286-
layoutView.children[13].map(RawInitializerClauseSyntax.init(raw:))
21287-
}
21288-
21289-
public var unexpectedBetweenInitializerAndTrailingComma: RawUnexpectedNodesSyntax? {
21290-
layoutView.children[14].map(RawUnexpectedNodesSyntax.init(raw:))
21291-
}
21292-
2129321281
public var trailingComma: RawTokenSyntax? {
21294-
layoutView.children[15].map(RawTokenSyntax.init(raw:))
21282+
layoutView.children[13].map(RawTokenSyntax.init(raw:))
2129521283
}
2129621284

2129721285
public var unexpectedAfterTrailingComma: RawUnexpectedNodesSyntax? {
21298-
layoutView.children[16].map(RawUnexpectedNodesSyntax.init(raw:))
21286+
layoutView.children[14].map(RawUnexpectedNodesSyntax.init(raw:))
2129921287
}
2130021288
}
2130121289

Sources/SwiftSyntax/generated/raw/RawSyntaxValidation.swift

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2551,7 +2551,7 @@ func validateLayout(layout: RawSyntaxBuffer, as kind: SyntaxKind) {
25512551
assertNoError(kind, index, verify(element, as: RawTupleTypeElementSyntax.self))
25522552
}
25532553
case .tupleTypeElement:
2554-
assert(layout.count == 17)
2554+
assert(layout.count == 15)
25552555
assertNoError(kind, 0, verify(layout[0], as: RawUnexpectedNodesSyntax?.self))
25562556
assertNoError(kind, 1, verify(layout[1], as: RawTokenSyntax?.self, tokenChoices: [.keyword("inout")]))
25572557
assertNoError(kind, 2, verify(layout[2], as: RawUnexpectedNodesSyntax?.self))
@@ -2565,10 +2565,8 @@ func validateLayout(layout: RawSyntaxBuffer, as kind: SyntaxKind) {
25652565
assertNoError(kind, 10, verify(layout[10], as: RawUnexpectedNodesSyntax?.self))
25662566
assertNoError(kind, 11, verify(layout[11], as: RawTokenSyntax?.self, tokenChoices: [.tokenKind(.ellipsis)]))
25672567
assertNoError(kind, 12, verify(layout[12], as: RawUnexpectedNodesSyntax?.self))
2568-
assertNoError(kind, 13, verify(layout[13], as: RawInitializerClauseSyntax?.self))
2568+
assertNoError(kind, 13, verify(layout[13], as: RawTokenSyntax?.self, tokenChoices: [.tokenKind(.comma)]))
25692569
assertNoError(kind, 14, verify(layout[14], as: RawUnexpectedNodesSyntax?.self))
2570-
assertNoError(kind, 15, verify(layout[15], as: RawTokenSyntax?.self, tokenChoices: [.tokenKind(.comma)]))
2571-
assertNoError(kind, 16, verify(layout[16], as: RawUnexpectedNodesSyntax?.self))
25722570
case .tupleType:
25732571
assert(layout.count == 7)
25742572
assertNoError(kind, 0, verify(layout[0], as: RawUnexpectedNodesSyntax?.self))

Sources/SwiftSyntax/generated/syntaxNodes/SyntaxNodes.swift

Lines changed: 8 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -11601,7 +11601,6 @@ public struct InheritedTypeSyntax: SyntaxProtocol, SyntaxHashable {
1160111601
/// - ``MatchingPatternConditionSyntax``.``MatchingPatternConditionSyntax/initializer``
1160211602
/// - ``OptionalBindingConditionSyntax``.``OptionalBindingConditionSyntax/initializer``
1160311603
/// - ``PatternBindingSyntax``.``PatternBindingSyntax/initializer``
11604-
/// - ``TupleTypeElementSyntax``.``TupleTypeElementSyntax/initializer``
1160511604
public struct InitializerClauseSyntax: SyntaxProtocol, SyntaxHashable {
1160611605
public let _syntaxNode: Syntax
1160711606

@@ -18462,7 +18461,6 @@ public struct TuplePatternElementSyntax: SyntaxProtocol, SyntaxHashable {
1846218461
/// - `colon`: `':'`?
1846318462
/// - `type`: ``TypeSyntax``
1846418463
/// - `ellipsis`: `'...'`?
18465-
/// - `initializer`: ``InitializerClauseSyntax``?
1846618464
/// - `trailingComma`: `','`?
1846718465
///
1846818466
/// ### Contained in
@@ -18503,9 +18501,7 @@ public struct TupleTypeElementSyntax: SyntaxProtocol, SyntaxHashable {
1850318501
type: some TypeSyntaxProtocol,
1850418502
_ unexpectedBetweenTypeAndEllipsis: UnexpectedNodesSyntax? = nil,
1850518503
ellipsis: TokenSyntax? = nil,
18506-
_ unexpectedBetweenEllipsisAndInitializer: UnexpectedNodesSyntax? = nil,
18507-
initializer: InitializerClauseSyntax? = nil,
18508-
_ unexpectedBetweenInitializerAndTrailingComma: UnexpectedNodesSyntax? = nil,
18504+
_ unexpectedBetweenEllipsisAndTrailingComma: UnexpectedNodesSyntax? = nil,
1850918505
trailingComma: TokenSyntax? = nil,
1851018506
_ unexpectedAfterTrailingComma: UnexpectedNodesSyntax? = nil,
1851118507
trailingTrivia: Trivia? = nil
@@ -18526,9 +18522,7 @@ public struct TupleTypeElementSyntax: SyntaxProtocol, SyntaxHashable {
1852618522
type,
1852718523
unexpectedBetweenTypeAndEllipsis,
1852818524
ellipsis,
18529-
unexpectedBetweenEllipsisAndInitializer,
18530-
initializer,
18531-
unexpectedBetweenInitializerAndTrailingComma,
18525+
unexpectedBetweenEllipsisAndTrailingComma,
1853218526
trailingComma,
1853318527
unexpectedAfterTrailingComma
1853418528
))) { (arena, _) in
@@ -18545,9 +18539,7 @@ public struct TupleTypeElementSyntax: SyntaxProtocol, SyntaxHashable {
1854518539
type.raw,
1854618540
unexpectedBetweenTypeAndEllipsis?.raw,
1854718541
ellipsis?.raw,
18548-
unexpectedBetweenEllipsisAndInitializer?.raw,
18549-
initializer?.raw,
18550-
unexpectedBetweenInitializerAndTrailingComma?.raw,
18542+
unexpectedBetweenEllipsisAndTrailingComma?.raw,
1855118543
trailingComma?.raw,
1855218544
unexpectedAfterTrailingComma?.raw
1855318545
]
@@ -18672,7 +18664,7 @@ public struct TupleTypeElementSyntax: SyntaxProtocol, SyntaxHashable {
1867218664
}
1867318665
}
1867418666

18675-
public var unexpectedBetweenEllipsisAndInitializer: UnexpectedNodesSyntax? {
18667+
public var unexpectedBetweenEllipsisAndTrailingComma: UnexpectedNodesSyntax? {
1867618668
get {
1867718669
return data.child(at: 12, parent: Syntax(self)).map(UnexpectedNodesSyntax.init)
1867818670
}
@@ -18681,16 +18673,16 @@ public struct TupleTypeElementSyntax: SyntaxProtocol, SyntaxHashable {
1868118673
}
1868218674
}
1868318675

18684-
public var initializer: InitializerClauseSyntax? {
18676+
public var trailingComma: TokenSyntax? {
1868518677
get {
18686-
return data.child(at: 13, parent: Syntax(self)).map(InitializerClauseSyntax.init)
18678+
return data.child(at: 13, parent: Syntax(self)).map(TokenSyntax.init)
1868718679
}
1868818680
set(value) {
1868918681
self = TupleTypeElementSyntax(data.replacingChild(at: 13, with: value?.data, arena: SyntaxArena()))
1869018682
}
1869118683
}
1869218684

18693-
public var unexpectedBetweenInitializerAndTrailingComma: UnexpectedNodesSyntax? {
18685+
public var unexpectedAfterTrailingComma: UnexpectedNodesSyntax? {
1869418686
get {
1869518687
return data.child(at: 14, parent: Syntax(self)).map(UnexpectedNodesSyntax.init)
1869618688
}
@@ -18699,24 +18691,6 @@ public struct TupleTypeElementSyntax: SyntaxProtocol, SyntaxHashable {
1869918691
}
1870018692
}
1870118693

18702-
public var trailingComma: TokenSyntax? {
18703-
get {
18704-
return data.child(at: 15, parent: Syntax(self)).map(TokenSyntax.init)
18705-
}
18706-
set(value) {
18707-
self = TupleTypeElementSyntax(data.replacingChild(at: 15, with: value?.data, arena: SyntaxArena()))
18708-
}
18709-
}
18710-
18711-
public var unexpectedAfterTrailingComma: UnexpectedNodesSyntax? {
18712-
get {
18713-
return data.child(at: 16, parent: Syntax(self)).map(UnexpectedNodesSyntax.init)
18714-
}
18715-
set(value) {
18716-
self = TupleTypeElementSyntax(data.replacingChild(at: 16, with: value?.data, arena: SyntaxArena()))
18717-
}
18718-
}
18719-
1872018694
public static var structure: SyntaxNodeStructure {
1872118695
return .layout([
1872218696
\Self.unexpectedBeforeInoutKeyword,
@@ -18731,9 +18705,7 @@ public struct TupleTypeElementSyntax: SyntaxProtocol, SyntaxHashable {
1873118705
\Self.type,
1873218706
\Self.unexpectedBetweenTypeAndEllipsis,
1873318707
\Self.ellipsis,
18734-
\Self.unexpectedBetweenEllipsisAndInitializer,
18735-
\Self.initializer,
18736-
\Self.unexpectedBetweenInitializerAndTrailingComma,
18708+
\Self.unexpectedBetweenEllipsisAndTrailingComma,
1873718709
\Self.trailingComma,
1873818710
\Self.unexpectedAfterTrailingComma
1873918711
])

0 commit comments

Comments
 (0)