Rough support for parsing @_package argument list

Author: stevapple

CodeGeneration/Sources/SyntaxSupport/gyb_generated/AttributeNodes.swift

@@ -78,7 +78,9 @@ public let ATTRIBUTE_NODES: [Node] = [
                  Child(name: "EffectsArguments",
                        kind: "EffectsArguments"),
                  Child(name: "DocumentationArguments",
-                       kind: "DocumentationAttributeArguments")
+                       kind: "DocumentationAttributeArguments"),
+                 Child(name: "PackageAttributeArguments",
+                       kind: "PackageAttributeArguments")
                ]),
          Child(name: "RightParen",
                kind: "RightParenToken",
@@ -236,6 +238,93 @@ public let ATTRIBUTE_NODES: [Node] = [
                isOptional: true)
        ]),
 
+  Node(name: "PackageAttributeArguments",
+       nameForDiagnostics: "@_package arguemnts",
+       description: "The arguments for the `@_package` attribute imitating `PackageDescription`",
+       kind: "Syntax",
+       children: [
+         Child(name: "LocationLabel",
+               kind: "IdentifierToken",
+               description: "The location label.",
+               tokenChoices: [
+                 "Identifier"
+               ],
+               textChoices: [
+                 "url",
+                 "path",
+                 "id"
+               ]),
+         Child(name: "LocationColon",
+               kind: "ColonToken",
+               tokenChoices: [
+                 "Colon"
+               ]),
+         Child(name: "Location",
+               kind: "StringLiteralToken",
+               description: "The location/identifier of package.",
+               tokenChoices: [
+                 "StringLiteral"
+               ]),
+         Child(name: "LocReqComma",
+               kind: "CommaToken",
+               description: "The comma separating the location and requirement",
+               tokenChoices: [
+                 "Comma"
+               ]),
+         Child(name: "RequirementLabel",
+               kind: "IdentifierToken",
+               description: "The requirement label.",
+               isOptional: true,
+               tokenChoices: [
+                 "Identifier"
+               ],
+               textChoices: [
+                 "from",
+                 "branch",
+                 "revision"
+               ]),
+         Child(name: "RequirementColon",
+               kind: "ColonToken",
+               isOptional: true,
+               tokenChoices: [
+                 "Colon"
+               ]),
+         Child(name: "Requirement",
+               kind: "Expr",
+               description: "The version requirement of package.",
+               isOptional: true),
+         Child(name: "ReqProdComma",
+               kind: "CommaToken",
+               description: "The comma separating the requirement and product name",
+               isOptional: true,
+               tokenChoices: [
+                 "Comma"
+               ]),
+         Child(name: "ProductLabel",
+               kind: "IdentifierToken",
+               description: "The product label.",
+               isOptional: true,
+               tokenChoices: [
+                 "Identifier"
+               ],
+               textChoices: [
+                 "product"
+               ]),
+         Child(name: "ProductColon",
+               kind: "ColonToken",
+               isOptional: true,
+               tokenChoices: [
+                 "Colon"
+               ]),
+         Child(name: "ProductName",
+               kind: "StringLiteralToken",
+               description: "The exact product name from package",
+               isOptional: true,
+               tokenChoices: [
+                 "StringLiteral"
+               ])
+       ]),
+
   Node(name: "ObjCSelectorPiece",
        nameForDiagnostics: "Objective-C selector piece",
        description: "A piece of an Objective-C selector. Either consisting of just anidentifier for a nullary selector, an identifier and a colon for alabeled argument or just a colon for an unlabeled argument",

Sources/SwiftParser/Attributes.swift

@@ -243,12 +243,7 @@ extension Parser {
       }
     case ._package:
       return parseAttribute(argumentMode: .required) { parser in
-        // TODO: @_package(...) argument parsing
-        if !parser.at(.rightParen) {
-          return .token(parser.consumeAnyToken())
-        } else {
-          return .token(parser.missingToken(.identifier))
-        }
+        return .packageAttributeArguments(parser.parsePackageAttributeArguments())
       }
     case ._private:
       return parseAttribute(argumentMode: .required) { parser in
@@ -881,6 +876,93 @@ extension Parser {
   }
 }
 
+extension Parser {
+  mutating func parsePackageAttribute() -> RawAttributeSyntax {
+    let (unexpectedBeforeAtSign, atSign) = self.expect(.atSign)
+    let (unexpectedBeforePackageToken, packageToken) = self.expect(.keyword(._package))
+    let (unexpectedBeforeLeftParen, leftParen) = self.expect(.leftParen)
+    let arguments = self.parsePackageAttributeArguments()
+    let (unexpectedBeforeRightParen, rightParen) = self.expect(.rightParen)
+    return RawAttributeSyntax(
+      unexpectedBeforeAtSign,
+      atSignToken: atSign,
+      unexpectedBeforePackageToken,
+      attributeName: RawTypeSyntax(RawSimpleTypeIdentifierSyntax(name: packageToken, genericArgumentClause: nil, arena: self.arena)),
+      unexpectedBeforeLeftParen,
+      leftParen: leftParen,
+      argument: .packageAttributeArguments(arguments),
+      unexpectedBeforeRightParen,
+      rightParen: rightParen,
+      arena: self.arena
+    )
+  }
+
+  mutating func parsePackageAttributeArguments() -> RawPackageAttributeArgumentsSyntax {
+    let (unexpectedBeforeLocationLabel, locationLabel) = self.parseArgumentLabel()
+    let (unexpectedBeforeLocationColon, locationColon) = self.expect(.colon)
+    let (unexpectedBeforeLocation, location) = self.expect(.stringLiteral)
+    let (unexpectedBeforeLocReqComma, locReqComma) = self.expect(.comma)
+    // FIXME: Requirement label/colon is optional.
+    let (unexpectedBeforeRequirementLabel, requirementLabel) = self.parseArgumentLabel()
+    let (unexpectedBeforeRequirementColon, requirementColon) = self.expect(.colon)
+    // TODO: Semantically parsing according to `locationLabel`.
+    let requirement = self.parseExpression()
+    // FIXME: What about unexpected token before comma?
+    guard self.at(.comma) else {
+      return RawPackageAttributeArgumentsSyntax(
+        unexpectedBeforeLocationLabel,
+        locationLabel: locationLabel,
+        unexpectedBeforeLocationColon,
+        locationColon: locationColon,
+        unexpectedBeforeLocation,
+        location: location,
+        unexpectedBeforeLocReqComma,
+        locReqComma: locReqComma,
+        unexpectedBeforeRequirementLabel,
+        requirementLabel: requirementLabel,
+        unexpectedBeforeRequirementColon,
+        requirementColon: requirementColon,
+        requirement: requirement,
+        reqProdComma: nil,
+        productLabel: nil,
+        productColon: nil,
+        productName: nil,
+        self.remainingTokensIfMaximumNestingLevelReached(),
+        arena: self.arena
+      )
+    }
+    let (unexpectedBeforeReqProdComma, reqProdComma) = self.expect(.comma)
+    let (unexpectedBeforeProductLabel, productLabel) = self.parseArgumentLabel()
+    let (unexpectedBeforeProductColon, productColon) = self.expect(.colon)
+    let (unexpectedBeforeProductName, productName) = self.expect(.stringLiteral)
+    return RawPackageAttributeArgumentsSyntax(
+      unexpectedBeforeLocationLabel,
+      locationLabel: locationLabel,
+      unexpectedBeforeLocationColon,
+      locationColon: locationColon,
+      unexpectedBeforeLocation,
+      location: location,
+      unexpectedBeforeLocReqComma,
+      locReqComma: locReqComma,
+      unexpectedBeforeRequirementLabel,
+      requirementLabel: requirementLabel,
+      unexpectedBeforeRequirementColon,
+      requirementColon: requirementColon,
+      requirement: requirement,
+      unexpectedBeforeReqProdComma,
+      reqProdComma: reqProdComma,
+      unexpectedBeforeProductLabel,
+      productLabel: productLabel,
+      unexpectedBeforeProductColon,
+      productColon: productColon,
+      unexpectedBeforeProductName,
+      productName: productName,
+      self.remainingTokensIfMaximumNestingLevelReached(),
+      arena: self.arena
+    )
+  }
+}
+
 extension Parser {
   mutating func parseConventionArguments() -> RawAttributeSyntax.Argument {
     if let witnessMethod = self.consume(if: .keyword(.witness_method)) {

Sources/SwiftSyntax/Documentation.docc/gyb_generated/SwiftSyntax.md

@@ -347,6 +347,7 @@ allows Swift tools to parse, inspect, generate, and transform Swift source code.
 - <doc:SwiftSyntax/TargetFunctionEntrySyntax>
 - <doc:SwiftSyntax/DeclNameSyntax>
 - <doc:SwiftSyntax/ImplementsAttributeArgumentsSyntax>
+- <doc:SwiftSyntax/PackageAttributeArgumentsSyntax>
 - <doc:SwiftSyntax/ObjCSelectorPieceSyntax>
 - <doc:SwiftSyntax/ObjCSelectorSyntax>
 - <doc:SwiftSyntax/DifferentiableAttributeArgumentsSyntax>