Merge pull request #1614 from ahoppen/ahoppen/5.9/double-right-crash

[5.9] Fix a precondition failure if a generic parameter clause had an additional closing right angle

Author: ahoppen

Sources/SwiftParser/Declarations.swift

@@ -544,7 +544,7 @@ extension Parser {
 
     let rangle: RawTokenSyntax
     if self.currentToken.starts(with: ">") {
-      rangle = self.consumeAnyToken(remapping: .rightAngle)
+      rangle = self.consumePrefix(">", as: .rightAngle)
     } else {
       rangle = RawTokenSyntax(missing: .rightAngle, arena: self.arena)
     }

Tests/SwiftParserTest/DeclarationTests.swift

@@ -1552,6 +1552,15 @@ final class DeclarationTests: XCTestCase {
       """
     )
   }
+
+  func testDoubleRightAngle() {
+    assertParse(
+      "func foo<A>1️⃣> test()",
+      diagnostics: [
+        DiagnosticSpec(message: "unexpected code '> test' before parameter clause")
+      ]
+    )
+  }
 }
 
 extension Parser.DeclAttributes {