Skip to content

Commit 89ba32f

Browse files
committed
Update for 'TupleElement'/'FunctionCallArgument' consolidation
1 parent cd7184a commit 89ba32f

File tree

3 files changed

+21
-21
lines changed

3 files changed

+21
-21
lines changed

Tests/SwiftSyntaxTest/CustomReflecatbleTests.swift

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -112,19 +112,19 @@ public class CustomReflectableTests: XCTestCase {
112112
leadingTrivia: [],
113113
trailingTrivia: [])
114114
let expr2 = SyntaxFactory.makeIntegerLiteralExpr(digits: token2)
115-
let elements = [SyntaxFactory.makeTupleElement(label: nil,
115+
let elements = [SyntaxFactory.makeTupleExprElement(label: nil,
116116
colon: nil,
117117
expression: expr1,
118118
trailingComma: nil),
119-
SyntaxFactory.makeTupleElement(label: nil,
119+
SyntaxFactory.makeTupleExprElement(label: nil,
120120
colon: nil,
121121
expression: expr2,
122122
trailingComma: nil)]
123-
let tuples = SyntaxFactory.makeTupleElementList(elements)
123+
let tuples = SyntaxFactory.makeTupleExprElementList(elements)
124124
return .init(syntax: tuples,
125125
expectedDumped: """
126-
▿ SwiftSyntax.TupleElementListSyntax
127-
▿ SwiftSyntax.TupleElementSyntax
126+
▿ SwiftSyntax.TupleExprElementListSyntax
127+
▿ SwiftSyntax.TupleExprElementSyntax
128128
- label: nil
129129
- colon: nil
130130
▿ expression: SwiftSyntax.IntegerLiteralExprSyntax
@@ -137,7 +137,7 @@ public class CustomReflectableTests: XCTestCase {
137137
▿ tokenKind: SwiftSyntax.TokenKind.integerLiteral
138138
- integerLiteral: "1"
139139
- trailingComma: nil
140-
▿ SwiftSyntax.TupleElementSyntax
140+
▿ SwiftSyntax.TupleExprElementSyntax
141141
- label: nil
142142
- colon: nil
143143
▿ expression: SwiftSyntax.IntegerLiteralExprSyntax
@@ -164,20 +164,20 @@ public class CustomReflectableTests: XCTestCase {
164164
leadingTrivia: [],
165165
trailingTrivia: [])
166166
let expr2 = SyntaxFactory.makeIntegerLiteralExpr(digits: token2)
167-
let elements = [SyntaxFactory.makeTupleElement(label: nil,
167+
let elements = [SyntaxFactory.makeTupleExprElement(label: nil,
168168
colon: nil,
169169
expression: expr1,
170170
trailingComma: nil),
171-
SyntaxFactory.makeTupleElement(label: nil,
171+
SyntaxFactory.makeTupleExprElement(label: nil,
172172
colon: nil,
173173
expression: expr2,
174174
trailingComma: nil)]
175-
let tuples = SyntaxFactory.makeTupleElementList(elements)
175+
let tuples = SyntaxFactory.makeTupleExprElementList(elements)
176176
return .init(syntax: tuples.reversed(),
177177
expectedDumped: """
178-
▿ SwiftSyntax.TupleElementListSyntax.Reversed
179-
▿ collection: SwiftSyntax.TupleElementListSyntax
180-
▿ SwiftSyntax.TupleElementSyntax
178+
▿ SwiftSyntax.TupleExprElementListSyntax.Reversed
179+
▿ collection: SwiftSyntax.TupleExprElementListSyntax
180+
▿ SwiftSyntax.TupleExprElementSyntax
181181
- label: nil
182182
- colon: nil
183183
▿ expression: SwiftSyntax.IntegerLiteralExprSyntax
@@ -190,7 +190,7 @@ public class CustomReflectableTests: XCTestCase {
190190
▿ tokenKind: SwiftSyntax.TokenKind.integerLiteral
191191
- integerLiteral: "1"
192192
- trailingComma: nil
193-
▿ SwiftSyntax.TupleElementSyntax
193+
▿ SwiftSyntax.TupleExprElementSyntax
194194
- label: nil
195195
- colon: nil
196196
▿ expression: SwiftSyntax.IntegerLiteralExprSyntax

Tests/SwiftSyntaxTest/SyntaxFactory.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ public class SyntaxFactoryAPITestCase: XCTestCase {
9898
public func testFunctionCallSyntaxBuilder() {
9999
let string = SyntaxFactory.makeStringLiteralExpr("Hello, world!")
100100
let printID = SyntaxFactory.makeVariableExpr("print")
101-
let arg = FunctionCallArgumentSyntax {
101+
let arg = TupleExprElementSyntax {
102102
$0.useExpression(string)
103103
}
104104
let call = FunctionCallExprSyntax {
@@ -109,13 +109,13 @@ public class SyntaxFactoryAPITestCase: XCTestCase {
109109
}
110110
XCTAssertEqual("\(call)", "print(\"Hello, world!\")")
111111

112-
let terminatorArg = FunctionCallArgumentSyntax {
112+
let terminatorArg = TupleExprElementSyntax {
113113
$0.useLabel(SyntaxFactory.makeIdentifier("terminator"))
114114
$0.useColon(SyntaxFactory.makeColonToken(trailingTrivia: .spaces(1)))
115115
$0.useExpression(SyntaxFactory.makeStringLiteralExpr(" "))
116116
}
117117
let callWithTerminator = call.withArgumentList(
118-
SyntaxFactory.makeFunctionCallArgumentList([
118+
SyntaxFactory.makeTupleExprElementList([
119119
arg.withTrailingComma(
120120
SyntaxFactory.makeCommaToken(trailingTrivia: .spaces(1))),
121121
terminatorArg
@@ -129,7 +129,7 @@ public class SyntaxFactoryAPITestCase: XCTestCase {
129129
public func testWithOptionalChild() {
130130
let string = SyntaxFactory.makeStringLiteralExpr("Hello, world!")
131131
let printID = SyntaxFactory.makeVariableExpr("print")
132-
let arg = FunctionCallArgumentSyntax {
132+
let arg = TupleExprElementSyntax {
133133
$0.useExpression(string)
134134
}
135135
let call1 = FunctionCallExprSyntax {

lit_tests/output/print_verify_tree.swift.withkind

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
// RUN: diff -u %t.result %S/output/print_verify_tree.swift.withkind
44

55
func </TokenSyntax><TokenSyntax>foo</TokenSyntax><FunctionSignatureSyntax><ParameterClauseSyntax><TokenSyntax>(</TokenSyntax><FunctionParameterListSyntax></FunctionParameterListSyntax><TokenSyntax>) </TokenSyntax></ParameterClauseSyntax></FunctionSignatureSyntax><CodeBlockSyntax><TokenSyntax>{</TokenSyntax><CodeBlockItemListSyntax><CodeBlockItemSyntax><IfConfigDeclSyntax><IfConfigClauseListSyntax><IfConfigClauseSyntax><TokenSyntax>
6-
#if </TokenSyntax><FunctionCallExprSyntax><IdentifierExprSyntax><TokenSyntax>swift</TokenSyntax></IdentifierExprSyntax><TokenSyntax>(</TokenSyntax><FunctionCallArgumentListSyntax><FunctionCallArgumentSyntax><PrefixOperatorExprSyntax><TokenSyntax>>=</TokenSyntax><FloatLiteralExprSyntax><TokenSyntax>3.2</TokenSyntax></FloatLiteralExprSyntax></PrefixOperatorExprSyntax></FunctionCallArgumentSyntax></FunctionCallArgumentListSyntax><TokenSyntax>)</TokenSyntax></FunctionCallExprSyntax><CodeBlockItemListSyntax><CodeBlockItemSyntax><FunctionCallExprSyntax><MemberAccessExprSyntax><IdentifierExprSyntax><TokenSyntax>
7-
components</TokenSyntax></IdentifierExprSyntax><TokenSyntax>.</TokenSyntax><TokenSyntax>append</TokenSyntax></MemberAccessExprSyntax><TokenSyntax>(</TokenSyntax><FunctionCallArgumentListSyntax><FunctionCallArgumentSyntax><StringLiteralExprSyntax><TokenSyntax>"</TokenSyntax><StringLiteralSegmentsSyntax><StringSegmentSyntax><TokenSyntax>-b \"</TokenSyntax></StringSegmentSyntax><ExpressionSegmentSyntax><TokenSyntax>\</TokenSyntax><TokenSyntax>(</TokenSyntax><FunctionCallArgumentListSyntax><FunctionCallArgumentSyntax><SubscriptExprSyntax><IdentifierExprSyntax><TokenSyntax>string</TokenSyntax></IdentifierExprSyntax><TokenSyntax>[</TokenSyntax><FunctionCallArgumentListSyntax><FunctionCallArgumentSyntax><PrefixOperatorExprSyntax><TokenSyntax>..<</TokenSyntax><FunctionCallExprSyntax><MemberAccessExprSyntax><IdentifierExprSyntax><TokenSyntax>string</TokenSyntax></IdentifierExprSyntax><TokenSyntax>.</TokenSyntax><TokenSyntax>index</TokenSyntax></MemberAccessExprSyntax><TokenSyntax>(</TokenSyntax><FunctionCallArgumentListSyntax><FunctionCallArgumentSyntax><TokenSyntax>before</TokenSyntax><TokenSyntax>: </TokenSyntax><MemberAccessExprSyntax><IdentifierExprSyntax><TokenSyntax>string</TokenSyntax></IdentifierExprSyntax><TokenSyntax>.</TokenSyntax><TokenSyntax>endIndex</TokenSyntax></MemberAccessExprSyntax></FunctionCallArgumentSyntax></FunctionCallArgumentListSyntax><TokenSyntax>)</TokenSyntax></FunctionCallExprSyntax></PrefixOperatorExprSyntax></FunctionCallArgumentSyntax></FunctionCallArgumentListSyntax><TokenSyntax>]</TokenSyntax></SubscriptExprSyntax></FunctionCallArgumentSyntax></FunctionCallArgumentListSyntax><TokenSyntax>)</TokenSyntax></ExpressionSegmentSyntax><StringSegmentSyntax><TokenSyntax>\"</TokenSyntax></StringSegmentSyntax></StringLiteralSegmentsSyntax><TokenSyntax>"</TokenSyntax></StringLiteralExprSyntax></FunctionCallArgumentSyntax></FunctionCallArgumentListSyntax><TokenSyntax>)</TokenSyntax></FunctionCallExprSyntax></CodeBlockItemSyntax></CodeBlockItemListSyntax></IfConfigClauseSyntax><IfConfigClauseSyntax><TokenSyntax>
6+
#if </TokenSyntax><FunctionCallExprSyntax><IdentifierExprSyntax><TokenSyntax>swift</TokenSyntax></IdentifierExprSyntax><TokenSyntax>(</TokenSyntax><TupleExprElementListSyntax><TupleExprElementSyntax><PrefixOperatorExprSyntax><TokenSyntax>>=</TokenSyntax><FloatLiteralExprSyntax><TokenSyntax>3.2</TokenSyntax></FloatLiteralExprSyntax></PrefixOperatorExprSyntax></TupleExprElementSyntax></TupleExprElementListSyntax><TokenSyntax>)</TokenSyntax></FunctionCallExprSyntax><CodeBlockItemListSyntax><CodeBlockItemSyntax><FunctionCallExprSyntax><MemberAccessExprSyntax><IdentifierExprSyntax><TokenSyntax>
7+
components</TokenSyntax></IdentifierExprSyntax><TokenSyntax>.</TokenSyntax><TokenSyntax>append</TokenSyntax></MemberAccessExprSyntax><TokenSyntax>(</TokenSyntax><TupleExprElementListSyntax><TupleExprElementSyntax><StringLiteralExprSyntax><TokenSyntax>"</TokenSyntax><StringLiteralSegmentsSyntax><StringSegmentSyntax><TokenSyntax>-b \"</TokenSyntax></StringSegmentSyntax><ExpressionSegmentSyntax><TokenSyntax>\</TokenSyntax><TokenSyntax>(</TokenSyntax><TupleExprElementListSyntax><TupleExprElementSyntax><SubscriptExprSyntax><IdentifierExprSyntax><TokenSyntax>string</TokenSyntax></IdentifierExprSyntax><TokenSyntax>[</TokenSyntax><TupleExprElementListSyntax><TupleExprElementSyntax><PrefixOperatorExprSyntax><TokenSyntax>..<</TokenSyntax><FunctionCallExprSyntax><MemberAccessExprSyntax><IdentifierExprSyntax><TokenSyntax>string</TokenSyntax></IdentifierExprSyntax><TokenSyntax>.</TokenSyntax><TokenSyntax>index</TokenSyntax></MemberAccessExprSyntax><TokenSyntax>(</TokenSyntax><TupleExprElementListSyntax><TupleExprElementSyntax><TokenSyntax>before</TokenSyntax><TokenSyntax>: </TokenSyntax><MemberAccessExprSyntax><IdentifierExprSyntax><TokenSyntax>string</TokenSyntax></IdentifierExprSyntax><TokenSyntax>.</TokenSyntax><TokenSyntax>endIndex</TokenSyntax></MemberAccessExprSyntax></TupleExprElementSyntax></TupleExprElementListSyntax><TokenSyntax>)</TokenSyntax></FunctionCallExprSyntax></PrefixOperatorExprSyntax></TupleExprElementSyntax></TupleExprElementListSyntax><TokenSyntax>]</TokenSyntax></SubscriptExprSyntax></TupleExprElementSyntax></TupleExprElementListSyntax><TokenSyntax>)</TokenSyntax></ExpressionSegmentSyntax><StringSegmentSyntax><TokenSyntax>\"</TokenSyntax></StringSegmentSyntax></StringLiteralSegmentsSyntax><TokenSyntax>"</TokenSyntax></StringLiteralExprSyntax></TupleExprElementSyntax></TupleExprElementListSyntax><TokenSyntax>)</TokenSyntax></FunctionCallExprSyntax></CodeBlockItemSyntax></CodeBlockItemListSyntax></IfConfigClauseSyntax><IfConfigClauseSyntax><TokenSyntax>
88
#else</TokenSyntax><CodeBlockItemListSyntax><CodeBlockItemSyntax><FunctionCallExprSyntax><MemberAccessExprSyntax><IdentifierExprSyntax><TokenSyntax>
9-
components</TokenSyntax></IdentifierExprSyntax><TokenSyntax>.</TokenSyntax><TokenSyntax>append</TokenSyntax></MemberAccessExprSyntax><TokenSyntax>(</TokenSyntax><FunctionCallArgumentListSyntax><FunctionCallArgumentSyntax><StringLiteralExprSyntax><TokenSyntax>"</TokenSyntax><StringLiteralSegmentsSyntax><StringSegmentSyntax><TokenSyntax>-b \"</TokenSyntax></StringSegmentSyntax><ExpressionSegmentSyntax><TokenSyntax>\</TokenSyntax><TokenSyntax>(</TokenSyntax><FunctionCallArgumentListSyntax><FunctionCallArgumentSyntax><FunctionCallExprSyntax><MemberAccessExprSyntax><IdentifierExprSyntax><TokenSyntax>string</TokenSyntax></IdentifierExprSyntax><TokenSyntax>.</TokenSyntax><TokenSyntax>substring</TokenSyntax></MemberAccessExprSyntax><TokenSyntax>(</TokenSyntax><FunctionCallArgumentListSyntax><FunctionCallArgumentSyntax><TokenSyntax>to</TokenSyntax><TokenSyntax>: </TokenSyntax><FunctionCallExprSyntax><MemberAccessExprSyntax><MemberAccessExprSyntax><IdentifierExprSyntax><TokenSyntax>string</TokenSyntax></IdentifierExprSyntax><TokenSyntax>.</TokenSyntax><TokenSyntax>characters</TokenSyntax></MemberAccessExprSyntax><TokenSyntax>.</TokenSyntax><TokenSyntax>index</TokenSyntax></MemberAccessExprSyntax><TokenSyntax>(</TokenSyntax><FunctionCallArgumentListSyntax><FunctionCallArgumentSyntax><TokenSyntax>before</TokenSyntax><TokenSyntax>: </TokenSyntax><MemberAccessExprSyntax><IdentifierExprSyntax><TokenSyntax>string</TokenSyntax></IdentifierExprSyntax><TokenSyntax>.</TokenSyntax><TokenSyntax>endIndex</TokenSyntax></MemberAccessExprSyntax></FunctionCallArgumentSyntax></FunctionCallArgumentListSyntax><TokenSyntax>)</TokenSyntax></FunctionCallExprSyntax></FunctionCallArgumentSyntax></FunctionCallArgumentListSyntax><TokenSyntax>)</TokenSyntax></FunctionCallExprSyntax></FunctionCallArgumentSyntax></FunctionCallArgumentListSyntax><TokenSyntax>)</TokenSyntax></ExpressionSegmentSyntax><StringSegmentSyntax><TokenSyntax>\"</TokenSyntax></StringSegmentSyntax></StringLiteralSegmentsSyntax><TokenSyntax>"</TokenSyntax></StringLiteralExprSyntax></FunctionCallArgumentSyntax></FunctionCallArgumentListSyntax><TokenSyntax>)</TokenSyntax></FunctionCallExprSyntax></CodeBlockItemSyntax></CodeBlockItemListSyntax></IfConfigClauseSyntax></IfConfigClauseListSyntax><TokenSyntax>
9+
components</TokenSyntax></IdentifierExprSyntax><TokenSyntax>.</TokenSyntax><TokenSyntax>append</TokenSyntax></MemberAccessExprSyntax><TokenSyntax>(</TokenSyntax><TupleExprElementListSyntax><TupleExprElementSyntax><StringLiteralExprSyntax><TokenSyntax>"</TokenSyntax><StringLiteralSegmentsSyntax><StringSegmentSyntax><TokenSyntax>-b \"</TokenSyntax></StringSegmentSyntax><ExpressionSegmentSyntax><TokenSyntax>\</TokenSyntax><TokenSyntax>(</TokenSyntax><TupleExprElementListSyntax><TupleExprElementSyntax><FunctionCallExprSyntax><MemberAccessExprSyntax><IdentifierExprSyntax><TokenSyntax>string</TokenSyntax></IdentifierExprSyntax><TokenSyntax>.</TokenSyntax><TokenSyntax>substring</TokenSyntax></MemberAccessExprSyntax><TokenSyntax>(</TokenSyntax><TupleExprElementListSyntax><TupleExprElementSyntax><TokenSyntax>to</TokenSyntax><TokenSyntax>: </TokenSyntax><FunctionCallExprSyntax><MemberAccessExprSyntax><MemberAccessExprSyntax><IdentifierExprSyntax><TokenSyntax>string</TokenSyntax></IdentifierExprSyntax><TokenSyntax>.</TokenSyntax><TokenSyntax>characters</TokenSyntax></MemberAccessExprSyntax><TokenSyntax>.</TokenSyntax><TokenSyntax>index</TokenSyntax></MemberAccessExprSyntax><TokenSyntax>(</TokenSyntax><TupleExprElementListSyntax><TupleExprElementSyntax><TokenSyntax>before</TokenSyntax><TokenSyntax>: </TokenSyntax><MemberAccessExprSyntax><IdentifierExprSyntax><TokenSyntax>string</TokenSyntax></IdentifierExprSyntax><TokenSyntax>.</TokenSyntax><TokenSyntax>endIndex</TokenSyntax></MemberAccessExprSyntax></TupleExprElementSyntax></TupleExprElementListSyntax><TokenSyntax>)</TokenSyntax></FunctionCallExprSyntax></TupleExprElementSyntax></TupleExprElementListSyntax><TokenSyntax>)</TokenSyntax></FunctionCallExprSyntax></TupleExprElementSyntax></TupleExprElementListSyntax><TokenSyntax>)</TokenSyntax></ExpressionSegmentSyntax><StringSegmentSyntax><TokenSyntax>\"</TokenSyntax></StringSegmentSyntax></StringLiteralSegmentsSyntax><TokenSyntax>"</TokenSyntax></StringLiteralExprSyntax></TupleExprElementSyntax></TupleExprElementListSyntax><TokenSyntax>)</TokenSyntax></FunctionCallExprSyntax></CodeBlockItemSyntax></CodeBlockItemListSyntax></IfConfigClauseSyntax></IfConfigClauseListSyntax><TokenSyntax>
1010
#endif</TokenSyntax></IfConfigDeclSyntax></CodeBlockItemSyntax></CodeBlockItemListSyntax><TokenSyntax>
11-
}</TokenSyntax></CodeBlockSyntax></FunctionDeclSyntax></CodeBlockItemSyntax></CodeBlockItemListSyntax><TokenSyntax></TokenSyntax></SourceFileSyntax>
11+
}</TokenSyntax></CodeBlockSyntax></FunctionDeclSyntax></CodeBlockItemSyntax></CodeBlockItemListSyntax><TokenSyntax></TokenSyntax></SourceFileSyntax>

0 commit comments

Comments
 (0)