Skip to content

Commit 8a75944

Browse files
authored
Merge pull request #1776 from ahoppen/ahoppen/isstartofline
Migrate `!currentToken.isStartOfLine` to `TokenSpec(allowStartOfLine: false)`
2 parents ca81f39 + ca197d0 commit 8a75944

File tree

3 files changed

+13
-17
lines changed

3 files changed

+13
-17
lines changed

Sources/SwiftParser/Declarations.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1122,7 +1122,7 @@ extension Parser {
11221122
let (unexpectedBeforeDeinitKeyword, deinitKeyword) = self.eat(handle)
11231123
var unexpectedNameAndSignature: [RawSyntax?] = []
11241124
unexpectedNameAndSignature.append(self.consume(if: TokenSpec(.identifier, allowAtStartOfLine: false)).map(RawSyntax.init))
1125-
if self.at(.leftParen) && !self.currentToken.isAtStartOfLine {
1125+
if self.at(TokenSpec(.leftParen, allowAtStartOfLine: false)) {
11261126
unexpectedNameAndSignature.append(RawSyntax(parseFunctionSignature()))
11271127
}
11281128
let items = self.parseOptionalCodeBlock()
@@ -1374,7 +1374,7 @@ extension Parser {
13741374
value: value,
13751375
arena: self.arena
13761376
)
1377-
} else if self.at(.leftParen), !self.currentToken.isAtStartOfLine,
1377+
} else if self.at(TokenSpec(.leftParen, allowAtStartOfLine: false)),
13781378
let typeAnnotationUnwrapped = typeAnnotation
13791379
{
13801380
// If we have a '(' after the type in the annotation, the type annotation

Sources/SwiftParser/Parser.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -603,7 +603,7 @@ extension Parser {
603603

604604
let beforePeriodWhitespace = previousNode?.raw.trailingTriviaByteLength ?? 0 > 0 || self.currentToken.leadingTriviaByteLength > 0
605605
let afterPeriodWhitespace = self.currentToken.trailingTriviaByteLength > 0 || self.peek().leadingTriviaByteLength > 0
606-
let afterContainsAnyNewline = self.peek().flags.contains(.isAtStartOfLine)
606+
let afterContainsAnyNewline = self.peek().isAtStartOfLine
607607

608608
let period = self.consumeAnyToken()
609609

Sources/SwiftParser/Types.swift

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -295,15 +295,13 @@ extension Parser {
295295
continue
296296
}
297297

298-
if !self.currentToken.isAtStartOfLine {
299-
if self.at(.postfixQuestionMark) {
300-
base = RawTypeSyntax(self.parseOptionalType(base))
301-
continue
302-
}
303-
if self.at(.exclamationMark) {
304-
base = RawTypeSyntax(self.parseImplicitlyUnwrappedOptionalType(base))
305-
continue
306-
}
298+
if self.at(TokenSpec(.postfixQuestionMark, allowAtStartOfLine: false)) {
299+
base = RawTypeSyntax(self.parseOptionalType(base))
300+
continue
301+
}
302+
if self.at(TokenSpec(.exclamationMark, allowAtStartOfLine: false)) {
303+
base = RawTypeSyntax(self.parseImplicitlyUnwrappedOptionalType(base))
304+
continue
307305
}
308306

309307
break
@@ -780,11 +778,9 @@ extension Parser.Lookahead {
780778
return false
781779
}
782780

783-
if !self.currentToken.isAtStartOfLine {
784-
if self.at(.postfixQuestionMark) || self.at(.exclamationMark) {
785-
self.consumeAnyToken()
786-
continue
787-
}
781+
if self.at(TokenSpec(.postfixQuestionMark, allowAtStartOfLine: false)) || self.at(TokenSpec(.exclamationMark, allowAtStartOfLine: false)) {
782+
self.consumeAnyToken()
783+
continue
788784
}
789785

790786
break

0 commit comments

Comments
 (0)