[Macros] Move checkMacroDefinition() to SwiftSyntaxMacroExpansion module

Macro deifnition checking is only meant to be used by something that
expands macros (e.g. compiler). Not for macro implementation.

Author: rintaro

Package.swift

@@ -180,10 +180,17 @@ let package = Package(
 
     .target(
       name: "SwiftSyntaxMacroExpansion",
-      dependencies: ["SwiftSyntax", "SwiftSyntaxMacros"],
+      dependencies: ["SwiftSyntax", "SwiftSyntaxMacros", "SwiftDiagnostics"],
       exclude: ["CMakeLists.txt"]
     ),
 
+    .testTarget(
+      name: "SwiftSyntaxMacroExpansionTest",
+      dependencies: [
+        "SwiftSyntax", "_SwiftSyntaxTestSupport", "SwiftSyntaxMacroExpansion", "SwiftSyntaxBuilder",
+      ]
+    ),
+
     // MARK: SwiftSyntaxMacrosTestSupport
 
     .target(

Sources/SwiftCompilerPluginMessageHandling/Macros.swift

@@ -125,7 +125,9 @@ extension CompilerPluginMessageHandler {
         // Make a single element array by collapsing the results into a string.
         expandedSources = [
           SwiftSyntaxMacroExpansion.collapse(
-            expansions: expansions, for: role, attachedTo: declarationNode
+            expansions: expansions,
+            for: role,
+            attachedTo: declarationNode
           )
         ]
       } else {

Sources/SwiftSyntaxMacroExpansion/CMakeLists.txt

@@ -1,5 +1,7 @@
 add_swift_host_library(SwiftSyntaxMacroExpansion
+  FunctionParameterUtils.swift
   MacroExpansion.swift
+  MacroReplacement.swift
 )
 
 target_link_libraries(SwiftSyntaxMacroExpansion PUBLIC

Sources/SwiftSyntaxMacros/FunctionParameterUtils.swift renamed to Sources/SwiftSyntaxMacroExpansion/FunctionParameterUtils.swift

@@ -1,3 +1,15 @@
+//===----------------------------------------------------------------------===//
+//
+// This source file is part of the Swift.org open source project
+//
+// Copyright (c) 2023 Apple Inc. and the Swift project authors
+// Licensed under Apache License v2.0 with Runtime Library Exception
+//
+// See https://swift.org/LICENSE.txt for license information
+// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
+//
+//===----------------------------------------------------------------------===//
+
 import SwiftSyntax
 @_spi(MacroExpansion) import SwiftSyntaxMacros
 
@@ -355,9 +367,10 @@ public func collapse<Node: SyntaxProtocol>(
   var separator: String = "\n\n"
 
   if role == .accessor,
-     let varDecl = declarationNode.as(VariableDeclSyntax.self),
-     let binding = varDecl.bindings.first,
-     binding.accessor == nil {
+    let varDecl = declarationNode.as(VariableDeclSyntax.self),
+    let binding = varDecl.bindings.first,
+    binding.accessor == nil
+  {
     let indentation = String(repeating: " ", count: 4)
 
     expansions = expansions.map({ indent($0, with: indentation) })

Sources/SwiftSyntaxMacroExpansion/MacroExpansion.swift

@@ -22,9 +22,7 @@ add_swift_host_library(SwiftSyntaxMacros
 
   AbstractSourceLocation.swift
   BasicMacroExpansionContext.swift
-  FunctionParameterUtils.swift
   MacroExpansionContext.swift
-  MacroReplacement.swift
   MacroSystem.swift
   Syntax+MacroEvaluation.swift
 )

Sources/SwiftSyntaxMacros/MacroReplacement.swift renamed to Sources/SwiftSyntaxMacroExpansion/MacroReplacement.swift

@@ -11,10 +11,9 @@
 //===----------------------------------------------------------------------===//
 
 import SwiftDiagnostics
-import SwiftParser
 import SwiftSyntax
 import SwiftSyntaxBuilder
-import SwiftSyntaxMacros
+import SwiftSyntaxMacroExpansion
 import _SwiftSyntaxTestSupport
 import XCTest