Skip to content

Commit be28272

Browse files
committed
Use Trivia(joining:) in SyntaxCollections
We've introduced `Trivia(joining: [Trivia], separator: [Trivia])` to generate doc comments from multiple pieces, and already use this approach in `SyntaxNodesFile` for nodes themselves, and for node children documentation. This commit switches from joining pieces manually to using `Trivia(joining:)` in `SyntaxCollectionsFile` so that we use the same approach everywhere.
1 parent b4fbbd9 commit be28272

File tree

1 file changed

+2
-9
lines changed

1 file changed

+2
-9
lines changed

CodeGeneration/Sources/generate-swift-syntax/templates/swiftsyntax/SyntaxCollectionsFile.swift

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -17,18 +17,11 @@ import Utils
1717

1818
let syntaxCollectionsFile = SourceFileSyntax(leadingTrivia: copyrightHeader) {
1919
for node in SYNTAX_NODES.compactMap(\.collectionNode) {
20-
let documentationSections = [
20+
let documentation = SwiftSyntax.Trivia(joining: [
2121
node.documentation,
2222
node.grammar,
2323
node.containedIn,
24-
]
25-
26-
let documentation =
27-
documentationSections
28-
.filter { !$0.isEmpty }
29-
.map { [$0] }
30-
.joined(separator: [Trivia.newline, Trivia.docLineComment("///"), Trivia.newline])
31-
.reduce(Trivia(), +)
24+
])
3225

3326
try! StructDeclSyntax(
3427
"""

0 commit comments

Comments
 (0)