Merge pull request #1812 from ahoppen/ahoppen/5.9/fix-code-generation

ahoppen · web-flow · commit ddcc9b2ad705 · 2023-06-19T15:06:11.000+02:00
Fix SyntaxRewriterFile.swift to generate the expected SyntaxRewriter.swift
diff --git a/CodeGeneration/Sources/generate-swiftsyntax/templates/swiftsyntax/SyntaxRewriterFile.swift b/CodeGeneration/Sources/generate-swiftsyntax/templates/swiftsyntax/SyntaxRewriterFile.swift
@@ -343,7 +343,7 @@ let syntaxRewriterFile = SourceFileSyntax(leadingTrivia: copyrightHeader) {
       public func rewrite(_ node: Syntax) -> Syntax {
         let rewritten = self.visit(node)
         return withExtendedLifetime(rewritten) {
-          return Syntax(node.data.replacingSelf(rewritten.raw, arena: rewritten.raw.arena))
+          return Syntax(node.data.replacingSelf(rewritten.raw, arena: SyntaxArena()))
         }
       }
       """

Original file line number	Diff line number	Diff line change
`@@ -343,7 +343,7 @@ let syntaxRewriterFile = SourceFileSyntax(leadingTrivia: copyrightHeader) {`
`343`	`343`	`public func rewrite(_ node: Syntax) -> Syntax {`
`344`	`344`	`let rewritten = self.visit(node)`
`345`	`345`	`return withExtendedLifetime(rewritten) {`
`346`		`- return Syntax(node.data.replacingSelf(rewritten.raw, arena: rewritten.raw.arena))`
	`346`	`+ return Syntax(node.data.replacingSelf(rewritten.raw, arena: SyntaxArena()))`
`347`	`347`	`}`
`348`	`348`	`}`
`349`	`349`	`"""`