Move tests from DiagnosticTests to other test files

Now that `AssertParse` is able to assert for diagnostics, it doesn’t make sense to keep the diagnostic test cases in a separate test file.

Author: ahoppen

Sources/SwiftParser/SwiftParser.docc/FixingBugs.md

@@ -57,7 +57,7 @@ Fixing the first case where the parser does not recover according to the user’
 
 To add a new, more contextual diagnostic, perform the following steps.
 
-1. Add a test case to `DiagnosticTests.swift` like the following:
+1. Add a test case in `SwiftParserTest` that looks like the following
     
     ```swift
     AssertParse(

Tests/SwiftParserTest/Declarations.swift

@@ -351,6 +351,72 @@ final class DeclarationTests: XCTestCase {
       """
     )
   }
+
+  func testMissingColonInFunctionSignature() {
+    AssertParse(
+      "(first second #^DIAG^#Int)",
+      { $0.parseFunctionSignature() },
+      diagnostics: [
+        DiagnosticSpec(message: "Expected ':' in function parameter")
+      ]
+    )
+  }
+
+  func testExtraArgumentLabelsInFunctionSignature() {
+    AssertParse(
+      "(first second #^DIAG^#third fourth: Int)",
+      { $0.parseFunctionSignature() },
+      diagnostics: [
+        DiagnosticSpec(message: "Unexpected text 'third fourth' found in function parameter")
+      ]
+    )
+  }
+
+  func testMissingClosingParenInFunctionSignature() {
+    AssertParse(
+      "(first second: Int#^DIAG^#",
+      { $0.parseFunctionSignature() },
+      diagnostics: [
+        DiagnosticSpec(message: "Expected ')' to end parameter clause")
+      ]
+    )
+  }
+
+  func testMissingOpeningParenInFunctionSignature() {
+    AssertParse(
+      "#^DIAG^#first second: Int)",
+      { $0.parseFunctionSignature() },
+      diagnostics: [
+        DiagnosticSpec(message: "Expected '(' to start parameter clause")
+      ]
+    )
+  }
+
+  func testNoParamsForFunction() {
+    AssertParse(
+      """
+      class MyClass {
+        func withoutParameters#^DIAG^#
+
+        func withParameters() {}
+      }
+      """,
+      diagnostics: [
+        DiagnosticSpec(message: "Expected argument list in function declaration")
+      ]
+    )
+  }
+
+  func testThrowsInWrongLocation() {
+    AssertParse(
+      "() -> #^DIAG^#throws Int",
+      { $0.parseFunctionSignature() },
+      diagnostics: [
+        DiagnosticSpec(message: "'throws' may only occur before '->'", fixIts: ["Move 'throws' before '->'"])
+      ],
+      fixedSource: "() throws -> Int"
+    )
+  }
 }
 
 extension Parser.DeclAttributes {

Tests/SwiftParserTest/DiagnosticTests.swift

@@ -70,4 +70,13 @@ final class DirectiveTests: XCTestCase {
        """
     )
   }
+
+  public func testUnterminatedPoundIf() {
+    AssertParse(
+      "#if test#^DIAG^#",
+      diagnostics: [
+        DiagnosticSpec(message: "Expected '#endif' in declaration")
+      ]
+    )
+  }
 }

Tests/SwiftParserTest/Directives.swift

@@ -285,4 +285,13 @@ final class ExpressionTests: XCTestCase {
       """
     )
   }
+
+  func testMissingColonInTernary() {
+    AssertParse(
+      "foo ? 1#^DIAG^#",
+      diagnostics: [
+        DiagnosticSpec(message: "Expected ':' after '? ...' in ternary expression")
+      ]
+    )
+  }
 }

Tests/SwiftParserTest/Expressions.swift

@@ -105,4 +105,16 @@ final class StatementTests: XCTestCase {
       """
     )
   }
+
+  func testCStyleForLoop() {
+    AssertParse(
+      """
+      #^DIAG^#for let x = 0; x < 10; x += 1, y += 1 {
+      }
+      """,
+      diagnostics: [
+        DiagnosticSpec(message: "C-style for statement has been removed in Swift 3", highlight: "let x = 0; x < 10; x += 1, y += 1 ")
+      ]
+    )
+  }
 }