Move SyntaxEnum from gyb to codegen #1151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
approved these changes
Dec 15, 2022
kimdv
force-pushed
the
kimdv/move-SyntaxEnum-to-codegen
branch
4 times, most recently
from
43533d2 to
f89def7
Compare
4 tasks
kimdv
force-pushed
the
kimdv/move-SyntaxEnum-to-codegen
branch
from
f89def7 to
1264fba
Compare
kimdv
force-pushed
the
kimdv/move-SyntaxEnum-to-codegen
branch
from
1264fba to
4444b13
Compare
kimdv
commented
Dec 16, 2022
kimdv
commented
Dec 16, 2022
| @@ -12,807 +14,1069 @@ | |||
| // | |||
| //===----------------------------------------------------------------------===// | |||
|
|
|||
| /// Enum to exhaustively switch over all different syntax nodes. | |||
There was a problem hiding this comment.
Not sure why, but it started to ignore this, even we have it here:
There was a problem hiding this comment.
Oh, looks like the source file’s leading trivia is overriding the first node’s trivia. I’m fixing it here: #1154
There was a problem hiding this comment.
I’m OK to leave it as-is for now. The comment will start appearing once we update CodeGeneration to include a SwiftSyntaxBuilder version that includes my PR.
kimdv
force-pushed
the
kimdv/move-SyntaxEnum-to-codegen
branch
from
4444b13 to
dedd6c1
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.